[✨feat] CompanyName 구현 #53
Open
+92
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
기업명을 값 객체로 다루기 위한 CompanyName 클래스를 구현했습니다. - from() 정적 팩터리 메서드 제공 - 비어 있거나 64자를 초과하는 값에 대한 유효성 검증 포함 - VO 특성을 위한 equals, hashCode, toString 오버라이딩
- CompanyName VO의 유효성 검증을 위한 에러 코드 2종 추가 - INVALID_COMPANY_NAME_EMPTY : 기업명이 비어 있을 경우 - INVALID_COMPANY_NAME_TOO_LONG : 기업명이 64자를 초과할 경우
- 유효한 값 입력 시 CompanyName 정상 생성 여부 검증 - 공백 입력 시 INVALID_COMPANY_NAME_EMPTY 예외 발생 테스트 - 64자 초과 입력 시 INVALID_COMPANY_NAME_TOO_LONG 예외 발생 테스트
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the CompanyName value object to encapsulate company name data with built-in validation rules. Key changes include:
- Implementation of the CompanyName VO with private constructor and validation.
- Addition of static factory method CompanyName.from().
- Updates to the InternshipErrorCode enum to include company name error codes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/kotlin/com/terning/server/kotlin/domain/internshipAnnouncement/CompanyNameTest.kt | Added tests to validate correct creation and exception handling for CompanyName. |
| src/main/kotlin/com/terning/server/kotlin/domain/internshipAnnouncement/InternshipErrorCode.kt | Added error codes specific to company name validation. |
| src/main/kotlin/com/terning/server/kotlin/domain/internshipAnnouncement/CompanyName.kt | Implemented the CompanyName value object with validation and proper overrides. |
Comments suppressed due to low confidence (1)
src/main/kotlin/com/terning/server/kotlin/domain/internshipAnnouncement/CompanyName.kt:29
- Consider adding tests for equals, hashCode, and toString methods to ensure the value object behaves correctly in all scenarios.
override fun equals(other: Any?): Boolean = this === other || (other is CompanyName && value == other.value)
leeeyubin
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Work Description
CompanyNameVO를 구현했습니다.value를 가지고 있으며, 생성 시 유효성 검증을 수행합니다.from()을 통해 생성하도록 제한하였습니다.equals,hashCode,toString을 오버라이드했습니다.💭 Thoughts
유효성 검증 책임을 한 곳에 집중하도록 설계했습니다.
각 검증을
init블록에서 직접 호출하여 의도를 더 잘 드러내는 방식으로 구성했습니다.InternshipException을 통해 처리하고,InternshipErrorCode항목을 별도로 정의해도메인 일관성과 API 응답 처리의 명확성을 함께 고려했습니다.
✅ Testing Result
🗂 Related Issue