[✨feat] InternshipTitle 구현 #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 인턴십 제목이 비어있는 경우를 처리하는 INVALID_INTERNSHIP_TITLE_EMPTY 코드 추가 - 인턴십 제목이 64자를 초과하는 경우를 처리하는 INVALID_INTERNSHIP_TITLE_TOO_LONG 코드 추가
- 인턴십 제목을 관리하는 값 객체(VO) `InternshipTitle` 구현 - 제목이 비어있거나 64자를 초과할 경우 예외 발생 - `equals`, `hashCode`, `toString` 재정의
- from 메서드가 유효한 값에서 정상 생성되는 경우 테스트 - 비어 있거나 공백뿐인 입력에 대한 예외 처리 테스트 - 64자를 초과하는 입력에 대한 예외 처리 테스트
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the InternshipTitle value object to encapsulate internship title logic and enforce domain-specific validations. Key changes include:
- Implementation of the InternshipTitle VO with validations for non-blank and maximum length constraints.
- Addition of unit tests covering valid, blank, and overly long title scenarios.
- Extension of the InternshipErrorCode enum to include error codes for invalid internship titles.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/kotlin/com/terning/server/kotlin/domain/internshipAnnouncement/InternshipTitleTest.kt | Added unit tests for the new InternshipTitle validations |
| src/main/kotlin/com/terning/server/kotlin/domain/internshipAnnouncement/InternshipTitle.kt | Implemented the InternshipTitle VO with appropriate validations |
| src/main/kotlin/com/terning/server/kotlin/domain/internshipAnnouncement/InternshipErrorCode.kt | Added new error codes for internship title validation failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Work Description
InternshipTitleVO(Value Object)를 구현했습니다.InternshipException과InternshipErrorCode를 활용하여 명확하게 구분했습니다.@Embeddable어노테이션을 활용해 JPA 내장 타입으로 매핑되며, DB와의 연동을 고려한 설계입니다.💭 Thoughts
isBlank()를 사용해 체크했습니다.trim()처리를 하지 않은 이유는, 제목에 양끝 공백이 의도적으로 포함될 가능성도 고려했기 때문입니다.✅ Testing Result
🗂 Related Issue