Maintenance 202604#63
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe pull request adds Python 3.14 support to the project by updating the CI test matrix to target Python 3.14 instead of 3.13, adding a Python 3.14 classifier to the package metadata, and documenting a message URL conversion rule in the Slack documentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 56.40% 56.40%
=======================================
Files 28 28
Lines 1982 1982
=======================================
Hits 1118 1118
Misses 864 864
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/tool/goof/slack.md (1)
119-121: Clarify terminology: "digits" instead of "decimals".The term "decimals" is imprecise here. Consider using "digits" or more specifically "the microsecond portion" for technical accuracy. The last six digits represent microseconds in the timestamp format.
📝 Suggested revision
-The message ID for this message URL is `1740421792.358899`: Just take the last -URL path fragment, strip the leading `p`, and separate the last six decimals -with a dot. +The message ID for this message URL is `1740421792.358899`: Just take the last +URL path fragment, strip the leading `p`, and insert a dot before the last six +digits (the microsecond portion).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/tool/goof/slack.md` around lines 119 - 121, Update the wording that describes how to derive the message ID from a Slack message URL: replace the imprecise term "decimals" with "digits" or explicitly "the microsecond portion" when referring to the last six characters; keep the same extraction steps (take the last URL path fragment, strip the leading `p`, then insert a dot before the final six digits) and use the example message ID `1740421792.358899` to show the microsecond portion clearly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/main.yml:
- Around line 26-28: The CI matrix currently under the python-version key only
lists "3.8" and "3.14", but pyproject.toml declares support for Python 3.13;
update the workflow matrix (the python-version entry) to include "3.13" (e.g.,
add "3.13" alongside "3.14" and keep "3.8") so the pipeline runs tests for all
declared supported versions and stays in sync with pyproject.toml.
---
Nitpick comments:
In `@docs/tool/goof/slack.md`:
- Around line 119-121: Update the wording that describes how to derive the
message ID from a Slack message URL: replace the imprecise term "decimals" with
"digits" or explicitly "the microsecond portion" when referring to the last six
characters; keep the same extraction steps (take the last URL path fragment,
strip the leading `p`, then insert a dot before the final six digits) and use
the example message ID `1740421792.358899` to show the microsecond portion
clearly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a04bb0b4-6edc-41b9-ab54-dc8addafeeea
📒 Files selected for processing (3)
.github/workflows/main.ymldocs/tool/goof/slack.mdpyproject.toml
| python-version: | ||
| - "3.8" | ||
| - "3.14" |
There was a problem hiding this comment.
CI no longer tests Python 3.13 despite declared support.
The test matrix now validates Python 3.8 and 3.14, but Python 3.13 (which is still listed as supported in pyproject.toml line 67) is no longer being tested. This creates a gap between the declared compatibility and actual CI coverage.
Consider including Python 3.13 in the matrix alongside 3.14 to maintain comprehensive coverage of all supported versions.
🔧 Suggested fix to include both 3.13 and 3.14
python-version:
- "3.8"
+ - "3.13"
- "3.14"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| python-version: | |
| - "3.8" | |
| - "3.14" | |
| python-version: | |
| - "3.8" | |
| - "3.13" | |
| - "3.14" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/main.yml around lines 26 - 28, The CI matrix currently
under the python-version key only lists "3.8" and "3.14", but pyproject.toml
declares support for Python 3.13; update the workflow matrix (the python-version
entry) to include "3.13" (e.g., add "3.13" alongside "3.14" and keep "3.8") so
the pipeline runs tests for all declared supported versions and stays in sync
with pyproject.toml.
There was a problem hiding this comment.
@coderabbitai: It will be good enough, and saves a bit of cycles / resources.
There was a problem hiding this comment.
@amotl — Understood! Testing the oldest supported version (3.8) and the newest (3.14) as bookends is a perfectly reasonable strategy to balance coverage with CI resource usage. Happy to defer to your judgment here.
✏️ Learnings added
Learnt from: amotl
Repo: tech-writing/rapporto PR: 63
File: .github/workflows/main.yml:26-28
Timestamp: 2026-04-25T18:17:01.165Z
Learning: In the `tech-writing/rapporto` repository, the maintainer intentionally tests only the oldest and newest supported Python versions in CI (e.g., 3.8 and 3.14) to save CI cycles/resources, rather than including every intermediate version. Do not flag missing intermediate Python versions in the CI matrix as an issue.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
amotl
force-pushed
the
ci-maintenance-202604
branch
from
c2a635b to
47b9d18
Compare
1 participant
This and that.