Skip to content

print newest deps #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 186 commits into
base: master
Choose a base branch
from
Open

Conversation

cdzwm
Copy link

@cdzwm cdzwm commented Apr 21, 2022

When conflict deps found, print the depency of newest version.

@technomancy
Copy link
Owner

Thanks for this patch.

I think overall it's good to surface this information, but the way it's presented in this implementation is not particularly clear. Simply saying Suggest: ... is confusing because it's presented alongside the suggestion to use :exclusions and it's not obvious how the two different suggestions are related. I think this needs some more thought put into it, but we could include it if the information is presented in a less confusing way.

There's also a couple technical issues with it; for one it removes :eval-in :leiningen which is pretty important, so that needs to be changed.

Also it appears to bring in a new dependency, which causes a lot of extra work for downstream packagers. As far as I can tell, this is only being used for a single function, which duplicates logic already available from Aether: https://github.com/technomancy/leiningen/blob/master/leiningen-core/src/leiningen/core/pedantic.clj#L68 Let's use the existing implementation instead of bringing in something redundant.

@cdzwm
Copy link
Author

cdzwm commented Apr 24, 2022

According to you suggestion, I make some modifications.

@cdzwm cdzwm closed this May 1, 2022
@technomancy
Copy link
Owner

Sorry, I haven't gotten a chance to look at this yet, but I don't think it needs to be closed. Was that intentional?

@cdzwm
Copy link
Author

cdzwm commented May 2, 2022

II'd like to think about this modification again. I think there are still some problems, but you can also take a look at it first and suggest some changes.

@cdzwm cdzwm reopened this May 2, 2022
@cdzwm
Copy link
Author

cdzwm commented May 17, 2022

I will make some fixes.

@cdzwm
Copy link
Author

cdzwm commented May 20, 2022

Fix is completed.

cucu and others added 3 commits May 20, 2022 13:08
And match the configuration arrangments for the host, i.e. support
LEIN_REPL_SOCKET, :repl-options :socket, and an nrepl config :socket.
This relies on an unreleased version of nrepl (likely to be 1.0.0).
It also doesn't completely clean up after itself because if nothing
else, the (server ...) future will be blocked forever on a promise.
robin_lilli and others added 25 commits July 9, 2024 14:02
Also prefix it with semicolons to avoid interfering with data.
Just helps avoid interfering with data in cases where the output is parsed.
Also update the tutorial that mentions this.

The Japanese translation of the tutorial still has the incorrect
description; we will need help updating it.

See https://codeberg.org/leiningen/leiningen/issues/46
Although a project's :active-profiles metadata is not currently part
of the publically specified API, it can be useful in middlewares.

Previously init-profiles, which is used by unmerge-profiles carried
over the :active-profiles from the incoming project, and since
:active-profiles is built solely via conj, this ended up not removing
profiles that were being unmerged.  To fix that, just clear the active
profiles in init-profiles before it rebuilds them.
…ia lein pom/java' (technomancy#54) from rlb/leiningen:unmerge-active-profiles-too into main

Reviewed-on: https://codeberg.org/leiningen/leiningen/pulls/54
Nrepl was upgraded to 1.3.0 in f82f809
… from gordonsyme/leiningen:gordon/sync-bootclasspath-deps into main

Reviewed-on: https://codeberg.org/leiningen/leiningen/pulls/55
@technomancy
Copy link
Owner

Sorry about this; for some reason github did not notify me about the changes here. This is a lot better. There's still a few issues I'd like to see fixed.

Possibly confusing dependencies found:
[clj-kondo "2022.12.10"] -> [org.babashka/sci "0.5.35"] -> [borkdude/edamame "1.0.0"]
 overrides
[metosin/reitit "0.7.2"] -> [metosin/reitit-malli "0.7.2"] -> [metosin/malli "0.16.4"] -> [borkdude/edamame "1.4.27"]

Consider using these exclusions:
[metosin/reitit "0.7.2" :exclusions [borkdude/edamame]]

OR

Adding the next line to the head of the project.clj file's depency vector:
[borkdude/edamame "1.4.27"]


In addition to using above exclusion method, you can also add all the following lines
to the head of the depency vector of your project.clj to resolve the confusing dependencies' problem:

[borkdude/edamame "1.4.27"]
----------------------------------------
  • Running the tests shows a bunch of reflection warnings now
  • It seems to repeat the same suggestion twice with different wording
  • Misspelling of dependency
  • No tests

technomancy and others added 4 commits March 22, 2025 14:17
This is redundant now, pomegranate already protects us from HTTP
downloads and will give a decent error when you try to use one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.