TWC - but it's built with hugo instead of jekyll #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for twc-site-nl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This changes adds a whole bunch of files for the new TWC NL website, this time built with Hugo. (Proposing to merge into `hugo-twc` branch just as a precaution for a double check to make sure it doesn't mess things up.) Main characteristics: - Sections: - **Landing page** with a gallery-style header, upcoming events and features resources - **Events** page with both upcoming and past events - **Resources** page with all resources, which currently is a single resource about collective labour agreements - **Join** page with a placeholder signup form --> still needs to be matched up with the Netlify integration - Language switch, between Dutch and English - Search built-in To dos: - Make sure that join form works 😄 - There are some issues in the styling of tags, so I've blocked those out for the moment so that they're not shown, but we might want to consider adding them back in at some point. - Documentation and contributing guides still describe the old site, so will have to update those at some point too
Hugo just sets a redirect on the root domain, where as netlify will look at the browser headers and then decide what is the best site for someone to be sent to (slightly nicer for natives)
Taken from here: 'https://github.com/gohugoio/hugoDocs/blob/master/netlify.toml#L11' This is surprisingly not well documented
This is opinionated. It's mainly to make things consistent so it's harder to miss things when developing. e.g. developers often don't test sites in multi languages. It is also harder to cater for the site url diff when dealing with multiple languages (e.g. js vs go vs. hugo in go)
This reverts commit d8f5293.
no more woff needed since woff2 has better compression, and it's ie11 which doesn't support woff.
There's some errors when running prettier, and I haven't currently got the patience to figure it out for now. I have put it to manual run via actions. It would be nice if prettie would show diffs, but I guess they just want to trust instead of nit pick 🤷
We can/should just use a new form eventually, however we have zapier limits etc. So this is just the easiest way (for now).
This change: - Adds a layout (`join-success`) for a landing page that the tech worker will land on once they've filled out the **Join** form - Adds EN and NL post-join landing pages that use the `join-success` layout, with some info about next steps now that the tech worker has completed the form Co-authored-by: Ben Naylor <[email protected]>
This change: - Updates the `button` shortcode, such that the link that you specify when the shortcode is used is language-relative, and you don't need to add a prefix to a specific language. - Removes language-specific prefixes on two pages on which the button shortcode was used. Co-authored-by: Ben Naylor <[email protected]>
This change shortens the text on the **Join** page, following an in-call review suggestion during the last meetup.
It interrupts form entry, and this is the easiest way to fix this for now.
It appears that the netlify preview site didn't pick up the redirects. It's picking up the netlify.toml though, so let's use that instead.
This changes adds comparatively more privacy-friendly analytics with [counter dev](https://counter.dev/).
b-n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
example.comas a URLFuture: