Skip to content

Logging #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 8, 2025
Merged

Logging #2

merged 12 commits into from
Nov 8, 2025

Conversation

@nicolaasuni
Copy link
Member

@nicolaasuni nicolaasuni commented Nov 8, 2025 •
edited
Loading

  • join Close() errors instead of logging them.
  • removed all logging.Close() calls.
  • renamed errtrace package to errutil and added utility functions

nicolaasuni
nicolaasuni commented Nov 8, 2025
View reviewed changes
Copy link
Member Author

@nicolaasuni nicolaasuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@coveralls
Copy link

coveralls commented Nov 8, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 19195264758

Details

  • 218 of 218 (100.0%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.969%
Totals Coverage Status
Change from base Build 19164904244: 0.0%
Covered Lines: 9656
Relevant Lines: 9659
💛 - Coveralls

@nicolaasuni nicolaasuni merged commit 1cdddec into main Nov 8, 2025
8 checks passed
@nicolaasuni nicolaasuni deleted the logging branch November 8, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolaasuni @coveralls