Skip to content

Update logger implementation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2025
Merged

Update logger implementation #4

merged 1 commit into from
Nov 11, 2025

Conversation

@nicolaasuni
Copy link
Member

@nicolaasuni nicolaasuni commented Nov 11, 2025 •
edited
Loading

Description

  • Added WithLogConfig bootstrap option to create the logger after the metrics and be able to register the metrics log-level counter.
  • Added logutil utility function to return the log level name.
  • Moved logutil hook logic to a separate file.

nicolaasuni
nicolaasuni commented Nov 11, 2025
View reviewed changes
Copy link
Member Author

@nicolaasuni nicolaasuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@coveralls
Copy link

coveralls commented Nov 11, 2025

Pull Request Test Coverage Report for Build 19264838233

Details

  • 50 of 50 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.969%
Totals Coverage Status
Change from base Build 19258744983: 0.0%
Covered Lines: 9744
Relevant Lines: 9747
💛 - Coveralls

@nicolaasuni nicolaasuni merged commit 8318901 into main Nov 11, 2025
8 checks passed
@nicolaasuni nicolaasuni deleted the logmetric branch November 11, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolaasuni @coveralls