-
Notifications
You must be signed in to change notification settings - Fork 148
Readme badges and pyproject cleanup #3378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a31e865
to
d35267a
Compare
I'd probably drop "ruff" and "pre-commit", the rest will lead a user to some artifacts or docs, while these two are more like a statement, "yup, we test it", and we don't expect these to ever be red for |
Agreed, I feel it the same way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the fresh copr link.
pyproject.toml
Outdated
"docutils>=0.16", # 0.16 is the current one available for RHEL9 | ||
"docutils>=0.16", | ||
"fmf>=1.7.0", | ||
"jinja2>=2.11.3", # 3.1.2 / 3.1.2 | ||
"packaging>=20", # 20 seems to be available with RHEL8 | ||
"pint>=0.16.1", # 0.16.1 | ||
"jinja2>=2.11.3", | ||
"packaging>=20", | ||
"pint>=0.16.1", | ||
"pydantic>=1.10.14", | ||
"pygments>=2.7.4", # 2.7.4 is the current one available for RHEL9 | ||
"requests>=2.25.1", # 2.28.2 / 2.31.0 | ||
"ruamel.yaml>=0.16.6", # 0.17.32 / 0.17.32 | ||
"urllib3>=1.26.5, <3.0", # 1.26.16 / 2.0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinhoyer why to drop these comments? seems till useful ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thrix Well, it seems unmaintainable, definitely was a mistake to add Fedora versions there. Mea culpa.
I presume we can add "explanation" for the lock, like "version xyz available on epel9 [04/2015]" or something", but not sure if there is any value as that is the case for all of them: "Min versions are dictated by minimal versions of RHEL/EPEL9 because we don't have something like #3605, this is also why we have Python 3.9, even though it will be EOL in 6 months"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just realized they are also copy-pasted to .pre-commit-config twice.
@@ -182,7 +183,7 @@ template = "dev" | |||
description = "Run scripts with multiple Python versions" | |||
|
|||
[[tool.hatch.envs.test.matrix]] | |||
python = ["3.9", "3.11", "3.12"] | |||
python = ["3.9", "3.12", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinhoyer I believe this is a significant change, it would desire it's own MR, ideally with the pyproject.yaml changes. Seems to be now hidden, I need to read the comments to find out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thrix hmm, afaik this is not being used in any pipeline and only affects hatch run test:foo
, isn't it?
fbcf277
to
ff7b516
Compare
@psss @happz I don't see what's wrong with that. It just tells people that this project uses pre-commit and ruff, which can increase the respect for the project, making them more likely to get involved. I mean, it's literally called a "badge". Alas, removed as requested. EDIT: oh and it can remind people to run |
ff7b516
to
10db97e
Compare
The dependency version bumps shouldn't make any difference in theory, but just to be safe, added full_test label |
Co-authored-by: Mario Casquero <[email protected]>
@martinhoyer LGTM, just a thought: do you think we can point the |
Seems to be rendering well in both HTML docs and man page: neither of these two shows any sign of badges :/ Which I guess is fine, yet a bit surprising. |
I'm not a friend with rst and have more experience with markdown. Will this render ok on PyPI page and other places? We also need to deal with man generation I presume?
PyPA should be ok based on:
github would look like this:

In pyproject, I've replaced Python 3.11 with 3.13 and removed the unmaintainable comments of what versions are available where.
Pull Request Checklist