-
Notifications
You must be signed in to change notification settings - Fork 148
Enable PermitRootLogin
for RHCOS
in testcloud
#3619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c983ba5
to
bc0ca88
Compare
thrix
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested both, Fedora CoreOS and RHCOS and I was able to boot and login successfully.
root@ibm-p8-kvm-03-guest-02:/var/home/thrix/.local/share/tmt/run-250/default/plan/tree[root@ibm-p8-kvm-03-guest-02 tree]# cat /etc/os-release
NAME="Red Hat Enterprise Linux CoreOS"
therazix
approved these changes
Apr 22, 2025
PermitRootLogin
for RHCOS
in testcloud
psss
approved these changes
Apr 23, 2025
frantisekz
approved these changes
Apr 26, 2025
Currently, tmt fails to provision RHCOS because RHCOS e.g. RHCOS-4.17.2 don't have "PermitRootLogin no" in /etc/ssh/sshd_config but disable PermitRootLogin 40-rhcos-defaults.conf. As a result, tmt can't connect to the guest machine. Follow [1] to permit root to login by SSH pubkey. Note FCOS e.g. fedora-coreos-41.20250130.3.0 doesn't have "PermitRootLogin no" so it actually permits root to have ssh login. So ssh_root_login.service is unneeded. [1] https://docs.fedoraproject.org/en-US/fedora-coreos/authentication/#_enabling_ssh_password_authentication Signed-off-by: Coiby Xu <[email protected]>
bc0ca88
to
2dd18a3
Compare
/packit build |
Chm, automerge does not wait for required chcecks when author cannot run them :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci | full test
Pull request is ready for the full test execution
plugin | testcloud
The testcloud virtual provision plugin
status | ready for merge
The only missing piece is to do the rebase the current 'main' and let the CI finish.
step | provision
Stuff related to the provision step
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tmt fails to provision RHCOS because RHCOS e.g. RHCOS-4.17.2
don't have "PermitRootLogin no" in /etc/ssh/sshd_config but disable
PermitRootLogin 40-rhcos-defaults.conf. As a result, tmt can't connect
to the guest machine.
Follow [1] to permit root to login by SSH pubkey.
Note FCOS e.g. fedora-coreos-41.20250130.3.0 doesn't have
"PermitRootLogin no" so it actually permits root to have ssh login. So
ssh_root_login.service is unneeded.
[1] https://docs.fedoraproject.org/en-US/fedora-coreos/authentication/#_enabling_ssh_password_authentication