Skip to content

Make sure os boot entry is not at the top of boot order #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skycastlelily
Copy link
Collaborator

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz
Copy link
Collaborator

happz commented Apr 14, 2025

See #3645, seems like you and @martinhoyer are dancing around the same problem.

@skycastlelily
Copy link
Collaborator Author

See #3645, seems like you and @martinhoyer are dancing around the same problem.

hmmm, Martin's mr is trying to fix my issue?
While this mr is trying implement your thought in the slack channel " but: isn't this patch something that we should eventually add to tmt-reboot?"

@happz
Copy link
Collaborator

happz commented Apr 14, 2025

See #3645, seems like you and @martinhoyer are dancing around the same problem.

hmmm, Martin's mr is trying to fix my issue? While this mr is trying implement your thought in the slack channel " but: isn't this patch something that we should eventually add to tmt-reboot?"

TBH, I'm not sure. I just saw both of you poking the same issue and the same part of the code. It made sense to me to get you two together so you could sort out what's the best approach.

@psss psss added the command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command label Apr 14, 2025
@skycastlelily
Copy link
Collaborator Author

skycastlelily commented Apr 14, 2025

I just saw both of you poking the same issue and the same part of the code

hmmm, np, IIUC , we are not poking the same issue, the key part of Martin's mr is efibootmgr -n (setting next boot) to make sure efi system boot correctly to the os,while mine is efibootmgr -o , to make sue the os boot entry not at the top of order. And looks like we are not poking the same code, either though I didn't get the whole picture, but it seems that he is trying to add a new script, while mine is make tmt-reboot work more robust :)
However, I may be wrong, Martin, feel free to ping me to talk about this 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command | reboot Support for rebooting guests during `tmt run` and the `tmt-reboot` command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants