Skip to content

Test should error out if pulling from guest fails #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

thrix
Copy link
Collaborator

@thrix thrix commented Apr 15, 2025

When the guest becomes unresponsive, make sure the test
errors out instead of staying in pending state.

Resolves #3647

Signed-off-by: Miroslav Vadkerti [email protected]

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • include a release note

@thrix thrix force-pushed the issue-3647 branch 2 times, most recently from 11cd5c3 to 169e32d Compare April 15, 2025 22:15
@thrix thrix requested a review from happz April 16, 2025 08:12
@thrix thrix added this to planning Apr 16, 2025
@github-project-automation github-project-automation bot moved this to backlog in planning Apr 16, 2025
@thrix thrix moved this from backlog to review in planning Apr 16, 2025
@thrix thrix requested a review from psss April 22, 2025 12:03
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thrix thrix moved this from review to merge in planning Apr 22, 2025
@happz happz added this to the 1.48 milestone Apr 24, 2025
@happz happz added the ci | full test Pull request is ready for the full test execution label Apr 25, 2025
thrix and others added 4 commits April 25, 2025 10:46
When the guest becomes unresponsive, make sure the test
errors out instead of staying in `pending` state.

Resolves #3647

Signed-off-by: Miroslav Vadkerti <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@happz happz enabled auto-merge (squash) April 25, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution
Projects
Status: merge
Development

Successfully merging this pull request may close these issues.

Test returns result pending when it aborts due to timeout
4 participants