CRB Feature Prepare Plugin #3695
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinhoyer
added
step | prepare
happz
reviewed
Apr 24, 2025
|
|
||
| except RunError as error: | ||
| # Log the original error details for better debugging | ||
| logger.debug(f"RunError details: {error}") |
There was a problem hiding this comment.
guest.execute() will log the error. It will log the whole output of the command executed, exit code, etc.
happz
reviewed
Apr 24, 2025
|
|
||
| try: | ||
| # Execute the command via shell. RunError is raised on failure. | ||
| guest.execute(Command(DEFAULT_SHELL, '-c', command_str)) |
There was a problem hiding this comment.
Make command_str command: ShellScript(...) and you can pass it to guest.execute() directly. guest.execute() will take care of adding DEFAULT_SHELL if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3650
5% of time implementing feature
95% of time pulling out hairs in
/tests/Gave up.
Pull Request Checklist