Skip to content

Add a background thread fetching guest logs periodically - #4995

Open
happz wants to merge 3 commits into
mainfrom
guest-log-update-worker
Open

Add a background thread fetching guest logs periodically#4995
happz wants to merge 3 commits into
mainfrom
guest-log-update-worker

Conversation

@happz

@happz happz commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz happz added this to planning Jun 15, 2026
@happz happz added the ci | full test Pull request is ready for the full test execution label Jun 15, 2026
@github-project-automation github-project-automation Bot moved this to backlog in planning Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a background thread GuestLogUpdater to periodically update guest logs, along with kickoff_logs and finalize_logs methods to manage the log collection lifecycle. Replace threading.Condition and threading.Event in GuestLogUpdater with a single threading.Event to prevent a runtime RuntimeError. Call self.finalize_logs(logger=logger) in the stop methods of the local and mock provision plugins to ensure guest logs are properly finalized and torn down.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tmt/guest/__init__.py
Comment thread tmt/steps/provision/local.py
Comment thread tmt/steps/provision/mock.py
@happz happz moved this from backlog to review in planning Jun 15, 2026
@happz
happz marked this pull request as ready for review June 15, 2026 13:51
@happz
happz force-pushed the guest-log-update-worker branch from 57c2c0e to 1081436 Compare June 29, 2026 12:05
@happz
happz force-pushed the guest-log-update-worker branch from 1081436 to 3321185 Compare August 20, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

1 participant