ty as yet another type checker - #5058
Merged
Merged
Conversation
happz
added
the
code | type annotations
happz
added
the
test coverage
happz
marked this pull request as ready for review
July 14, 2026 06:35
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates the ty pre-commit hook, configures its rules in pyproject.toml, and updates the return type of execute in tmt/guest/__init__.py to be optional. Correct the typo call-top-callable to call-non-callable in the pyproject.toml configuration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
LecrisUT
approved these changes
Jul 23, 2026
LecrisUT
left a comment
LecrisUT
left a comment
Member
There was a problem hiding this comment.
Should start type-checking the tests also at some point
lukaszachy
approved these changes
Aug 26, 2026
Still heavily reduced ruleset, but over time, things should improve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still heavily reduced ruleset, but over time, things should improve.
Pull Request Checklist