Add rsync-based "copy tree" strategy - #5111
Open
happz wants to merge 4 commits into
Open
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
happz
force-pushed
the
copy-tree-rsync-strategy
branch
from
August 10, 2026 10:26
0071b41 to
186f0e3
Compare
happz
force-pushed
the
copy-tree-rsync-strategy
branch
2 times, most recently
from
August 16, 2026 20:44
8779f08 to
ad5d751
Compare
happz
force-pushed
the
copy-tree-rsync-strategy
branch
from
August 19, 2026 18:16
ad5d751 to
c306bdb
Compare
happz
force-pushed
the
copy-tree-rsync-strategy
branch
from
August 20, 2026 13:25
c306bdb to
a8a0d31
Compare
happz
added
status | blocked
Contributor
Author
|
/packit build |
LecrisUT
approved these changes
Aug 21, 2026
| will be created. | ||
| :param tmpdir_creator: a context manager that, when invoked, would | ||
| create and hold a temporary directory. Some strategies may | ||
| require such a directory for their work. |
Member
There was a problem hiding this comment.
"Some strategies may require" -> "Some strategies do not use one even if provided". I think that's the more crucial thing to note.
Contributor
Author
There was a problem hiding this comment.
Hmm, I think it is more important this way: "if you don't provide tmpdir_creator callback, some strategies may not work" sounds stricter than "if you provide tmpdir_creator, some strategies may ignore it as they don't need it" to me.
Comment on lines
+115
to
+118
| logger.debug( | ||
| f"Copy tree '{src}' => '{dst}' using 'rsync -a' strategy" | ||
| " not possible without a temporary directory." | ||
| ) |
Member
There was a problem hiding this comment.
Would increase the debug level for this. It is deeper in our plumbing and frankly not every useful without a traceback to patch it.
Comment on lines
+110
to
+111
| :returns: ``True`` if successful, ``False`` if ``rsync`` command | ||
| fails with :py:class:`RunError`. |
happz
force-pushed
the
copy-tree-rsync-strategy
branch
from
August 26, 2026 21:36
a8a0d31 to
b7ba130
Compare
It is the preferred strategy, because, in the future, it will allow excluding files and directories (think ".gitignore"). However, since `rsync` requires a temporary directory to play correctly with runners like Testing Farm, the strategy will do nothing when caller provides no way to create such a temporary directory.
happz
force-pushed
the
copy-tree-rsync-strategy
branch
from
August 26, 2026 21:43
b7ba130 to
8b26fda
Compare
Contributor
Author
|
/packit build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is the preferred strategy, because, in the future, it will allow
excluding files and directories (think ".gitignore"). However, since
rsyncrequires a temporary directory to play correctly with runnerslike Testing Farm, the strategy will do nothing when caller provides no
way to create such a temporary directory.
Pull Request Checklist