Fix finish/shell scripts never running in image mode - #5125
Merged
Conversation
therazix
added
step | finish
LecrisUT
reviewed
Aug 18, 2026
LecrisUT
approved these changes
Aug 18, 2026
thrix
approved these changes
Aug 18, 2026
therazix
force-pushed
the
fvagner-image-mode
branch
2 times, most recently
from
August 18, 2026 14:30
0c5ee89 to
709214b
Compare
Member
|
/packit build |
tcornell-bus
force-pushed
the
fvagner-image-mode
branch
from
August 20, 2026 12:41
709214b to
bd94ae4
Compare
happz
approved these changes
Aug 20, 2026
tcornell-bus
pushed a commit
to tcornell-bus/tmt
that referenced
this pull request
Aug 21, 2026
This PR fixes `finish/shell` scripts being skipped on image-mode guests. Finish scripts now run immediately, `prepare/shell` is unchanged. Fixes teemtee#4917
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
finish/shellscripts being skipped on image-mode guests. Finish scripts now run immediately,prepare/shellis unchanged.Fixes #4917
Pull Request Checklist