Allow configuring the shared artifact repository name

[HabibRh26]

Fixes #5073

Pull Request Checklist

• implement the feature
• extend the test coverage
• modify the json schema
• include a release note

[LecrisUT]

Note that SHARED_REPO_NAME is used as a default in ArtifactInfo. You would have to pass the value from PrepareArtifactData down to those as well. Also might as well move the SHARED_REPO_NAME up to this level at this point

[psss]

Congrats for your first pull request, @HabibRh26! 😁 Looks good, two thoughts:

As this is adding a new option, it would be good to include a release note. These are stored under the pending directory:

• https://github.com/teemtee/tmt/tree/main/docs/releases/pending
• see also https://tmt.readthedocs.io/en/stable/contribute.html#checklist

What about extending some of the existing tests to exercise the newly added option? I think the basic test could be a good candidate:

tmt/tests/prepare/artifact/basic/plan.fmf

Lines 9 to 12 in e3f4b1a

	- name: Main artifact to test
	how: artifact
	provide:
	- file:../rpms/bar/bar-1.0-1.noarch.rpm

[happz]

Suggested change

	Name of the tmt generated repo containing all artifacts
	that are generated.
	""",
	Name of the tmt generated repo containing all artifacts
	that are generated.
	""",

[HabibRh26]

addressed here

[happz]

Import from the plugin, or, better, let plugin import from this library. At this moment, 'tmt-artifact-shared' string is duplicated, and we want just the single source of truth.

[HabibRh26]

I initially moved SHARED_REPO_NAME up to __init__.py based on @LecrisUT's suggestion (If I understand it correctly) to move it to the level where PrepareArtifactData owns the configuration. However, that created a string duplication since providers/__init__.py still needs the value for the ArtifactInfo.repo_id default, and importing it back from __init__.py would cause a circular import (__init__.py already imports from providers/__init__.py).

[HabibRh26]

Reverted to keep the constant in providers/__init__.py as the single source of truth

[HabibRh26]

addressed here

[happz]

/packit build

[HabibRh26]

/packit build

is the output of this command supposed to display here or somewhere else?

[tcornell-bus]

/packit build

is the output of this command supposed to display here or somewhere else?

It will kick off the build jobs and subsequent test jobs in the "checks" box below, you might need to scroll around in the box to see what its doing

[tcornell-bus]

/packit build

[HabibRh26]

Congrats for your first pull request, @HabibRh26! 😁 Looks good, two thoughts:

As this is adding a new option, it would be good to include a release note. These are stored under the pending directory:

* https://github.com/teemtee/tmt/tree/main/docs/releases/pending

* see also https://tmt.readthedocs.io/en/stable/contribute.html#checklist

What about extending some of the existing tests to exercise the newly added option? I think the basic test could be a good candidate:

tmt/tests/prepare/artifact/basic/plan.fmf

Lines 9 to 12 in e3f4b1a

	- name: Main artifact to test
	how: artifact
	provide:
	- file:../rpms/bar/bar-1.0-1.noarch.rpm

Release note added in 9866a397, test coverage in 11ba5d0b and log assertion in 01fc4371

[therazix]

LGTM.