Skip to content

#144 Import of Tenants: Corrected First- and Lastname order #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlwinEgger merged 3 commits into from
Jan 20, 2026
Merged

#144 Import of Tenants: Corrected First- and Lastname order #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
902cd29
#144 Import of Tenants: Corrected First- and Lastname order
AlwinEgger Jan 20, 2026
185501d
Corrected in sample-data
AlwinEgger Jan 20, 2026
9ffabd0
... and fixed test
AlwinEgger Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django/importer/create_sample_importer_tenant_property.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def create_sample_tenant_property_excel(filename="sample_tenant_property_import.
"", # Wohnung Id Eidg
"", # Wohnung Nummer Administrativ
"", # Id
"Max Muster", # Mieter Person Person Name Vorname
"Muster Max", # Mieter Person Person Name Vorname
"Testweg 5, 3011 Bern", # Mieter Person Person Adresse
"1001", # Mieter Person Person Id
"2024-01-01", # Verhaeltnis Gueltigvon
Expand Down
4 changes: 2 additions & 2 deletions django/importer/importer_tenant_property_it_wgn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,11 +348,11 @@
# Try to split into first and last name
name_parts = name_str.split()
if len(name_parts) >= 2:
first_name = name_parts[0]
last_name = " ".join(name_parts[1:])
last_name = name_parts[0]
first_name = " ".join(name_parts[1:])
else:
first_name = ""
last_name = name_str

Check warning on line 355 in django/importer/importer_tenant_property_it_wgn.py

View workflow job for this annotation

GitHub Actions / test

Missing coverage 

Missing coverage on lines 354-355

# Parse address info from "Mieter Person Person Adresse"
address_str = (row_data.get("Mieter Person Person Adresse", "") or "").strip()
Expand Down
2 changes: 1 addition & 1 deletion django/importer/tests/test_importer_tenant_property_it_wgn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def test_import_with_contract(self):
"", # Wohnung Id Eidg
"", # Wohnung Nummer Administrativ
"unit_002", # Id
"Max Muster", # Mieter Person Person Name Vorname
"Muster Max", # Mieter Person Person Name Vorname
"Testweg 1, 8000 Zürich", # Mieter Person Person Adresse
"person_001", # Mieter Person Person Id
"2024-01-01", # Verhaeltnis Gueltigvon
Expand Down
Loading