Fix trailing spaces in openshift-client task

[vdemeester]

Changes

Fix pre-existing trailing whitespace on lines 46, 59, and 61 of
task/openshift-client/0.2/openshift-client.yaml that causes the
yamllint CI check to fail with trailing-spaces errors on all PRs
touching this repository.

The three affected lines were blank/empty lines inside the results
block and script block that had invisible trailing spaces. Removed
with sed.

Submitter Checklist

• Follows the authoring recommendations
• Includes docs (if user facing) — N/A, no functional change
• Includes tests (for new tasks or changed functionality) — N/A, whitespace-only fix
• Meets the Tekton contributor standards
• Commit messages follow commit message best practices
• Has a kind label (/kind cleanup)
• Complies with Catalog Organization TEP — N/A, no structural change

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• task/openshift-client/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/kind cleanup

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: vdemeester / name: Vincent Demeester (2bfe08b)

[tekton-robot]

Catlin Output

FILE: task/openshift-client/0.2/openshift-client.yaml
WARN : Step "oc" uses image "quay.io/openshift/origin-cli:$(params.VERSION)" that contains variables; skipping validation

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s bash] failed:

In openshift-client-oc line 4:
cd $(workspaces.manifest-dir.path)
^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
   ^-----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

Did you mean: 
cd $(workspaces.manifest-dir.path) || exit


In openshift-client-oc line 8:
export KUBECONFIG=$(workspaces.kubeconfig-dir.path)/kubeconfig
       ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In openshift-client-oc line 10:
echo "" > $(results.RESULT.path)
          ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.


In openshift-client-oc line 12:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

[tekton-robot]

The following Tekton test failed:

Test name	Commit	Details	Required	Rerun command
pull-catalog-catlin-lint	2bfe08b	link	true	/test pull-catalog-catlin-lint

[tekton-robot]

Catlin Output

FILE: task/openshift-client/0.2/openshift-client.yaml
WARN : Step "oc" uses image "quay.io/openshift/origin-cli:$(params.VERSION)" that contains variables; skipping validation

Catlin script lint Output

ERROR: /usr/bin/shellcheck, [-s bash] failed:

In openshift-client-oc line 4:
cd $(workspaces.manifest-dir.path)
^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
   ^-----------------------------^ SC2046 (warning): Quote this to prevent word splitting.

Did you mean: 
cd $(workspaces.manifest-dir.path) || exit


In openshift-client-oc line 8:
export KUBECONFIG=$(workspaces.kubeconfig-dir.path)/kubeconfig
       ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In openshift-client-oc line 10:
echo "" > $(results.RESULT.path)
          ^--------------------^ SC2046 (warning): Quote this to prevent word splitting.


In openshift-client-oc line 12:
$(params.SCRIPT)
^--------------^ SC2091 (warning): Remove surrounding $() to avoid executing output (or use eval if intentional).

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2091 -- Remove surrounding $() to avoid e...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

[chmouel]

/lgtm