Skip to content

Fix pronoun in command usage text #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pronoun in command usage text #2617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cli/prerun/prerun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func PersistentPreRunE(p cli.Params) func(*cobra.Command, []string) error {

func WarnExperimental(cmd *cobra.Command) error {
if IsExperimental(cmd) {
fmt.Fprintf(cmd.OutOrStderr(), "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\n")
fmt.Fprintf(cmd.OutOrStderr(), "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\n")
}
return nil
}
Expand Down
16 changes: 8 additions & 8 deletions pkg/cmd/bundle/list_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,34 +48,34 @@ func TestListCommand(t *testing.T) {
{
name: "no-format",
format: "",
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
}, {
name: "name-format",
format: "name",
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\ntask.tekton.dev/foobar\n",
}, {
name: "yaml-format",
format: "yaml",
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\n" + examplePullPipeline + "---\n" + examplePullTask,
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\n" + examplePullPipeline + "---\n" + examplePullTask,
}, {
name: "specify-kind-task",
format: "name",
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
additionalArgs: []string{"Task"},
}, {
name: "specify-kind-task-lowercase-plural",
format: "name",
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
additionalArgs: []string{"tasks"},
}, {
name: "specify-kind-task-lowercase-singular",
format: "name",
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\ntask.tekton.dev/foobar\n",
additionalArgs: []string{"task"},
}, {
name: "specify-kind-pipeline",
format: "name",
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
additionalArgs: []string{"Pipeline"},
}, {
name: "specify-kind-name-dne",
Expand All @@ -85,7 +85,7 @@ func TestListCommand(t *testing.T) {
}, {
name: "specify-kind-name",
format: "name",
expectedStdout: "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
expectedStdout: "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\npipeline.tekton.dev/foobar\n",
additionalArgs: []string{"Pipeline", "foobar"},
},
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/pipeline/sign_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestSign(t *testing.T) {
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
expected := "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nPipeline testdata/pipeline.yaml is signed successfully \n"
expected := "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nPipeline testdata/pipeline.yaml is signed successfully \n"
test.AssertOutput(t, expected, out)

// verify the signed task
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/pipeline/verify_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ func TestVerify(t *testing.T) {
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
expected := "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nPipeline testdata/signed.yaml passes verification \n"
expected := "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nPipeline testdata/signed.yaml passes verification \n"
test.AssertOutput(t, expected, out)
}
2 changes: 1 addition & 1 deletion pkg/cmd/task/sign_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestSign(t *testing.T) {
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
expected := "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nTask testdata/task.yaml is signed successfully \n"
expected := "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nTask testdata/task.yaml is signed successfully \n"
test.AssertOutput(t, expected, out)

// verify the signed task
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/task/verify_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ func TestVerify(t *testing.T) {
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
expected := "*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)\nTask testdata/signed.yaml passes verification \n"
expected := "*Warning*: This is an experimental command, its usage and behavior can change in the next release(s)\nTask testdata/signed.yaml passes verification \n"
test.AssertOutput(t, expected, out)
}
Loading