docs: document StepAction support in Hub Resolver#10275
Conversation
The Hub Resolver supports `stepaction` as a `kind` value (see `supportedKinds` in pkg/resolution/resolver/hub/resolver.go), but the docs only listed `task` and `pipeline`. Update docs/hub-resolver.md to: - list `stepaction` as a supported `kind` value - note that Artifact Hub StepAction packages use the `tekton-stepaction` package type - add a StepAction resolution example, matching the existing Task and Pipeline examples Also note that, unlike `task`/`pipeline`, `stepaction` has no default catalog in resolveCatalogName, so `catalog` must be set explicitly. Fixes tektoncd#10202
|
|
|
/kind documentation |
|
/assign @vdemeester |
|
Hello @vdemeester ! This is my first open source contribution in a major, active codebase. hope it is upto the standards. If not, happy to review and rewrite :) |
| | Param Name | Description | Example Value | | ||
| |------------------|-------------------------------------------------------------------------------|------------------------------------------------------------| | ||
| | `catalog` | The catalog from where to pull the resource (Optional) | Default: `tekton-catalog-tasks` (for `task` kind); `tekton-catalog-pipelines` (for `pipeline` kind) | | ||
| | `catalog` | The catalog from where to pull the resource (Optional) | Default: `tekton-catalog-tasks` (for `task` kind); `tekton-catalog-pipelines` (for `pipeline` kind); no default for `stepaction` kind, so `catalog` must be set explicitly | |
There was a problem hiding this comment.
Interesting for the step action, I wonder if, as a follow-up, we should have a default for stepaction 🤔
There was a problem hiding this comment.
yeah that would be great, @copilot create an issue for this
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
Hello guys! Just wanted to bump this PR up. Was wondering if there's something that might be stopping from a merger. |
Changes
Update docs/hub-resolver.md to:
stepactionas a supportedkindvaluetekton-stepactionpackage typeAlso note that, unlike
task/pipeline,stepactionhas no default catalog in resolveCatalogName, socatalogmust be set explicitly.Resolves #10202
update
hub-resolver.md: add documentation for StepActionSubmitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes