Skip to content

Conversation

pramodbindal
Copy link
Member

@pramodbindal pramodbindal commented Oct 10, 2025

Changes

This PR is for the Fixes #9059

When a TaskRun is timed out then default behavior is to delete the corresponding pod and there is no way to debug the pod later

With this fix, POD will not be deleted when task-run is timed out and feature flag 'keep-pod-on-cancel' is set to true.
This is same behavior as it was with cancelled task runs.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes


If Feature flag "keep-pod-on-cancel" is set to true then pods corresponding  to TaskRun will be not be deleted  when TaskRun Times Out. Earlier pod was retained only if it taskrun was canceled.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 10, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2025
@pramodbindal
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 10, 2025
@pramodbindal pramodbindal changed the title WIP - Change the default behavior of Pipelines/Task Timeout triggers Pod Deletion Change the default behavior of Pipelines/Task Timeout triggers Pod Deletion Oct 10, 2025
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2025
@waveywaves waveywaves self-assigned this Oct 10, 2025
@pramodbindal pramodbindal changed the title Change the default behavior of Pipelines/Task Timeout triggers Pod Deletion Pods for timed out TaskRuns should not be deleted when "keep-pod-on-cancel" feature flag is true Oct 10, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from waveywaves after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pramodbindal pramodbindal force-pushed the main branch 3 times, most recently from a20f005 to 60b8e1a Compare October 10, 2025 12:11
@pramodbindal
Copy link
Member Author

/retest

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this ?

    When a TaskRun is timed out then default behaviour  is to delete the corresponding pod and there is no way to debug the pod later
    With this fix, POD will not be deleted when taskrun is timed out and feature flag 'keep-pod-on-cancel' is set to true.
    This is same behavour as it was with cancled task runs.

Signed-off-by: Pramod Bindal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Do no delete pod on Pipelines/Task Timeout

4 participants