-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Pods for timed out TaskRuns should not be deleted when "keep-pod-on-cancel" feature flag is true #9075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/kind bug |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a20f005
to
60b8e1a
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a test for this ?
When a TaskRun is timed out then default behaviour is to delete the corresponding pod and there is no way to debug the pod later With this fix, POD will not be deleted when taskrun is timed out and feature flag 'keep-pod-on-cancel' is set to true. This is same behavour as it was with cancled task runs. Signed-off-by: Pramod Bindal <[email protected]>
Changes
This PR is for the Fixes #9059
When a TaskRun is timed out then default behavior is to delete the corresponding pod and there is no way to debug the pod later
With this fix, POD will not be deleted when task-run is timed out and feature flag 'keep-pod-on-cancel' is set to true.
This is same behavior as it was with cancelled task runs.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes