-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Add digest validation support to HTTP resolver #9171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add digest validation support to HTTP resolver #9171
Conversation
|
/kind feature |
68fd341 to
d6f4f58
Compare
|
I think that one E2E job failure is flake because before there was three jobs were failing |
076f32b to
9c6db5d
Compare
3a6c745 to
0b02160
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vdemeester I guess E2E failure is flake because they are not consistent, yeah? |
Yes, working on fixing it but it might take some times. One thing as well, e2e tests that change the configmaps are making the things flaky (because most things run in parallels) - I am working on fixing this as well. |
@vdemeester I think #9224 fixes that, right? |
0b02160 to
969fb68
Compare
It is trying yes. |
|
/retest |
waveywaves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggestions with a doc update and early validations to fail fast before a comparatively compute heavy call
4f79992 to
3c94798
Compare
1b89317 to
580e811
Compare
This commit introduces content hash verification for the HTTP resolver by adding support for optional digest validation using SHA256 and SHA512 algorithms. Changes: - Add new 'digest' parameter accepting '<algorithm>:<hash>' format where algorithm can be 'sha256' or 'sha512' - Implement digest validation logic using constant-time comparison to prevent timing-based side-channel attacks - Add comprehensive unit tests covering valid matches, mismatches, invalid formats, and unsupported algorithms - Add E2E tests to verify digest validation in real cluster scenarios - Enable 'enable-http-resolver' feature flag in default configuration - Update documentation with digest parameter description, usage examples, and commands to calculate SHA256/SHA512 hashes Security considerations: - Uses constant-time comparison to prevent timing attacks - Digest validation is optional to maintain backward compatibility - Digest values are logged for debugging Fixes: tektoncd#8759 Signed-off-by: Zaki Shaikh <[email protected]>
580e811 to
fedb2ce
Compare
This commit introduces content hash verification for the HTTP resolver by adding support for optional digest validation using SHA256 and SHA512 algorithms.
Changes:
Security considerations:
Fixes: #8759
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes