fix(github-interceptor): use Error instead of Errorf for non-format strings#3108
Merged
tekton-robot merged 1 commit intoFeb 10, 2026
Merged
Conversation
…trings Go 1.24's stricter vet checks flag non-constant format strings passed to printf-like functions. The code was incorrectly using Errorf with err.Error() as the format string, which could cause issues if the error message contained % characters. This change uses Error() instead of Errorf() when no format arguments are needed, fixing the lint errors that were blocking dependabot PRs (tektoncd#2939, tektoncd#2961, tektoncd#3036). /kind bug Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
added
the
size/XS
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anithapriyanatarajan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Go 1.24's stricter vet checks flag non-constant format strings passed to printf-like functions. The code was incorrectly using
Errorfwitherr.Error()as the format string, which could cause issues if the error message contained%characters.This change uses
Error()instead ofErrorf()when no format arguments are needed, fixing the lint errors that were blocking dependabot PRs (#2939, #2961, #3036).Files changed:
tekton/ci/interceptors/github/pkg/github/issue_comment.gotekton/ci/interceptors/github/pkg/github/pull_request.gotekton/ci/interceptors/github/pkg/github/push.go/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.