Skip to content

Fix WorkerCount to read from ConfigMap instead of env var#21

Closed
infernus01 wants to merge 1 commit into
tektoncd:mainfrom
infernus01:workercount
Closed

Fix WorkerCount to read from ConfigMap instead of env var#21
infernus01 wants to merge 1 commit into
tektoncd:mainfrom
infernus01:workercount

Conversation

@infernus01

Copy link
Copy Markdown
Member

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign savitaashture after the PR has been reviewed.
You can assign the PR to them by writing /assign @savitaashture in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2025
@anithapriyanatarajan

Copy link
Copy Markdown
Contributor

@infernus01 - Right now we do not want to enable the worker count to be user configurable. Is there any specific reason we intend to have this change?

@tekton-robot

Copy link
Copy Markdown

@infernus01: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2025
@infernus01

Copy link
Copy Markdown
Member Author

@infernus01 - Right now we do not want to enable the worker count to be user configurable. Is there any specific reason we intend to have this change?

It seems to me like we have 'if' checks for configmap values and then getting values from env variables. It looked odd to me, but there might be some reason behind this. I'll reopen this if found something not good.

@infernus01 infernus01 closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants