Fix WorkerCount to read from ConfigMap instead of env var#21
Conversation
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@infernus01 - Right now we do not want to enable the worker count to be user configurable. Is there any specific reason we intend to have this change? |
|
@infernus01: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It seems to me like we have 'if' checks for configmap values and then getting values from env variables. It looked odd to me, but there might be some reason behind this. I'll reopen this if found something not good. |
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes