Skip to content

Add webhook validation for configmaps#24

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
infernus01:webhook-validation
Nov 5, 2025
Merged

Add webhook validation for configmaps#24
tekton-robot merged 1 commit into
tektoncd:mainfrom
infernus01:webhook-validation

Conversation

@infernus01

@infernus01 infernus01 commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Add webhook validation for configmaps
/kind enhancement

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

- Added admission webhook validation for pruner ConfigMaps to provide immediate error feedback when applying invalid configurations, preventing silent failures
- Webhook uses Tekton-style implementation with automatic certificate management and validates any ConfigMap with pruner configuration keys

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2025
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 28, 2025
@infernus01 infernus01 changed the title Add webhook validation for configmaps [WIP] Add webhook validation for configmaps Oct 28, 2025
@infernus01 infernus01 force-pushed the webhook-validation branch 2 times, most recently from d0eb58a to ba79c68 Compare October 29, 2025 06:29
@infernus01 infernus01 marked this pull request as ready for review October 29, 2025 06:43
@infernus01 infernus01 changed the title [WIP] Add webhook validation for configmaps Add webhook validation for configmaps Oct 29, 2025
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2025
@infernus01

infernus01 commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

The CI is failing because ValidatingWebhookConfiguration is getting created before the webhook pod ready that resulting in "connection refused" errors when ConfigMaps created.
Modified reusable-e2e.yaml to deploy resources in stages

@infernus01

infernus01 commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

/cc @anithapriyanatarajan

anithapriyanatarajan
anithapriyanatarajan reviewed Nov 3, 2025
View reviewed changes
Comment thread config/500-webhook.yaml Outdated
@infernus01

infernus01 commented Nov 3, 2025

Copy link
Copy Markdown
Member Author

/kind enhancement

@tekton-robot

tekton-robot commented Nov 3, 2025

Copy link
Copy Markdown

@infernus01: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@infernus01

infernus01 commented Nov 3, 2025

Copy link
Copy Markdown
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 3, 2025
@infernus01 infernus01 force-pushed the webhook-validation branch 4 times, most recently from 2345ce2 to 7cecc9f Compare November 4, 2025 11:21
@anithapriyanatarajan

anithapriyanatarajan commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

The CI is failing because ValidatingWebhookConfiguration is getting created before the webhook pod ready that resulting in "connection refused" errors when ConfigMaps created. Modified reusable-e2e.yaml to deploy resources in stages

This is handled.

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2025
@anithapriyanatarajan anithapriyanatarajan force-pushed the webhook-validation branch 6 times, most recently from 634628b to f650ee9 Compare November 5, 2025 00:34
@infernus01 infernus01 force-pushed the webhook-validation branch 2 times, most recently from 4f4979f to 5fe7d9b Compare November 5, 2025 05:04
@infernus01 @anithapriyanatarajan
Add webhook validation for configmaps
1df5f1f 
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
Co-authored-by: Anitha Priya Natarajan <anataraj@redhat.com>
@anithapriyanatarajan

anithapriyanatarajan commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@anithapriyanatarajan

anithapriyanatarajan commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

/approve

@tekton-robot

tekton-robot commented Nov 5, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anithapriyanatarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anithapriyanatarajan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@tekton-robot tekton-robot merged commit cccd0cb into tektoncd:main Nov 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pramodbindal pramodbindal Awaiting requested review from pramodbindal
@vdemeester vdemeester Awaiting requested review from vdemeester
@savitaashture savitaashture Awaiting requested review from savitaashture
@anithapriyanatarajan anithapriyanatarajan Awaiting requested review from anithapriyanatarajan

Assignees

@anithapriyanatarajan anithapriyanatarajan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infernus01 @tekton-robot @anithapriyanatarajan