Repository navigation
feat(e2e): add blob log e2e tests (S3/GCS) and fix LogMux auth header case bug - #1504
Open
adityavshinde wants to merge 1 commit into
Open
adityavshinde wants to merge 1 commit into
adityavshinde wants to merge 1 commit into
Conversation
tekton-robot
added
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/XXL
adityavshinde
force-pushed
the
test/blob-log-e2e
branch
8 times, most recently
from
October 6, 2026 17:16
cacfa5b to
2e67fb0
Compare
adityavshinde
force-pushed
the
test/blob-log-e2e
branch
5 times, most recently
from
October 19, 2026 10:06
1d0525d to
9f6c5cc
Compare
E2E tests for the v1alpha3 blob log plugin route with S3 (MinIO) and GCS (fake-gcs-server) backends: happy path, PipelineRun, no-logs, unauthorized, RBAC denied, large log (27MB, 10MB memory cap), and GCS emulator read path. Wired into e2e.sh. Fix LogMux metadata key casing: net/http canonical headers were not lowercased for gRPC metadata.Get, breaking auth on the plugin route. Unit test added. /kind feature Signed-off-by: adityavshinde <adishind@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
E2E tests for the v1alpha3 blob log plugin route with S3 (in-cluster MinIO)
and GCS (fake-gcs-server emulator) backends.
S3 tests (
e2e,blobs): happy path, PipelineRun cross-task isolation,no-logs (HTTP 200 + empty body), unauthorized, RBAC denied, large log
(27MB, 10MB memory cap via kubelet stats).
GCS test (
e2e,gcs_blob): pre-seeded data read throughgcsblobdriver.Vector is not used — its GCS sink speaks XML API which the emulator doesn't support.
Bug fix (
plugin_logs.go):LogMuxnow lowercases HTTP header keysbefore constructing gRPC metadata. Without this,
metadata.Get("authorization")never finds the token and every plugin log request fails auth. Unit test added.
Also: in-cluster MinIO manifests, Vector Helm setup,
e2e.shwiring,legacy
TestGCSLogmarked deprecated./kind feature
Submitter Checklist
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes