Repository navigation
Conversation
Only use static credentials when both S3_ACCESS_KEY_ID and S3_SECRET_ACCESS_KEY are set. Otherwise fall back to the default AWS credential chain, which allows web identity tokens (IRSA), instance profiles and the AWS_* environment variables to be used. Fixes tektoncd#665 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
tekton-robot
added
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
tekton-robot
added
the
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #665
The S3 log storage always built a static credentials provider from
S3_ACCESS_KEY_ID/S3_SECRET_ACCESS_KEY, even when they were empty, which overrode the default AWS credential chain. That made it impossible to use web identity tokens (IRSA), instance profiles or theAWS_*environment variables.Static credentials are now only used when both values are set. Otherwise
LoadDefaultConfigresolves credentials through the default chain, which includes the web identity provider. Existing configurations that set both values behave as before. The README documents that the two variables are optional.Tests:
TestInitConfigCredentialschecks that static credentials win when both are set, and that the default chain is used when they are missing or only the key id is set. I could not exercise a real IRSA setup locally./kind feature
Submitter Checklist
Release Notes