feat(metrics): Migration from OpenCensus to OpenTelemetry#1934
feat(metrics): Migration from OpenCensus to OpenTelemetry#1934tekton-robot merged 4 commits intotektoncd:mainfrom
Conversation
3c87b54 to
e1a5712
Compare
e1a5712 to
59027ed
Compare
khrm
left a comment
There was a problem hiding this comment.
Can you first run hack/update-codegen.sh ?
|
Please separate vendor and code changes into separate PR. It makes it easier to review. |
59027ed to
77e5835
Compare
|
Can you rebase this? Also, ensure that generated related changes are there with vendor update commit. |
|
Did you test the metrics? Can you write release note which mention any changes/breaking changes that user need to make? |
77e5835 to
8b27f4c
Compare
a44aee6 to
b91b547
Compare
b91b547 to
278b00c
Compare
6877d78 to
cd764a0
Compare
d483a25 to
835e347
Compare
835e347 to
a1eb0aa
Compare
The OTel migration bumped knative.dev/eventing to a version that starts a health probe server on port 8080 inside MainWithInformers. The event-listener sink's own HTTP server also listens on port 8080, causing "bind: address already in use" on startup, putting el-* pods into CrashLoopBackOff and breaking e2e tests. Co-authored-by: Khurram Baig <kbaig@redhat.com> Co-authored-by: Shubham Bhardwaj <shubbhar@redhat.com>
Bump knative and Pipeline to latest. Also ran ./hack/update-codegen.sh. Co-authored-by: Shubham Bhardwaj <shubbhar@redhat.com> Co-authored-by: Khurram Baig <kbaig@redhat.com>
|
Instead of having event_received_count_total, it's better to have event_received_total. |
Migration from OpenCensus to OTEL Co-authored-by: Shubham Bhardwaj <shubbhar@redhat.com> Co-authored-by: Khurram Baig <kbaig@redhat.com>
Co-authored-by: Shubham Bhardwaj <shubbhar@redhat.com> Co-authored-by: Khurram Baig <kbaig@redhat.com>
|
Thanks @khrm for a thorough review! |
|
I have updated the release note. Will merge soon. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Changes
Migrates Triggers metrics implementation from the deprecated OpenCensus library to OpenTelemetry, aligning with Knative's observability stack modernization.
Changes include:
go.opencensus.io/stats,stats/view,tag) with OpenTelemetry (go.opentelemetry.io/otel,otel/attribute,otel/metric) inpkg/sink/metrics.goandpkg/reconciler/metrics/metrics.goelDurationtometric.Float64Histogram,eventRcdCountandtriggeredResourcestometric.Int64Countereventlistener_count,triggerbinding_count,clustertriggerbinding_count,triggertemplate_count,clusterinterceptor_count) tometric.Float64Gaugeknative.dev/pkgtov0.0.0-20260120122510-4a022ed9999a(includes new observability package)knative.dev/eventingtov0.0.0-20260209140146-9e76da08faaa(compatible with newknative.dev/pkgwithout deprecated metrics package)tektoncd/pipelinetov1.10.0(OpenTelemetry migrated)K_OBSERVABILITY_CONFIGreplacingK_METRICS_CONFIGandK_TRACING_CONFIG)knative.dev/pkg/metrics/metricstestAll existing metrics continue to be exported with the same names and semantics. Counter metrics gain a
_totalsuffix per Prometheus naming conventions when using the OTel Prometheus exporter.fixes : #1964
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes