docs(skills): harden shipping-changes guard-chain rule (blood-lesson anti-pattern) - #33
Merged
Merged
Conversation
…son anti-pattern
Improve mode (cultivating-skills). Adds the anti-pattern I just hit in P3: never
wrap test+commit in a {...}/; sequential block — block commands run independently,
so a red test still lets commit run, degrading the guard from 'block' to 'log'.
Must use && short-circuit so a non-zero exit truly halts the chain. Also notes:
after changing source, find which stale assertion needs syncing or tests go red.
Trimmed recap table to stay within the 90-line body budget.
scan clean; npm test 379; verify:skills 25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improve-mode update to the
shipping-changesskill (viacultivating-skills). Adds a blood-lesson anti-pattern to the guard-chain iron law.Why
While shipping P3 (PR #32), I violated this skill's own core rule: I wrapped
npm testandgit commitin a single{ ...; ... }block. Block commands run independently, so a red test still letcommitrun — the guard degraded from block to log, and broken code reached the PR (caught only because the network happened to fail the merge).Change
Adds to 关4 (guarded commit) section:
Also trimmed the redundant recap table to stay within the 90-line body budget.
Verification
forge scan: clean (block=0 warn=0)&&guard chain this time (test && verify && commit) — 379 passed, 25 skills