Skip to content

fix: update subscriptions in device #1475

Merged
fgalan merged 6 commits intomasterfrom
fix/update_subscriptions_device
Feb 5, 2024
Merged

fix: update subscriptions in device #1475
fgalan merged 6 commits intomasterfrom
fix/update_subscriptions_device

Conversation

@AlvaroVega
Copy link
Copy Markdown
Member

@AlvaroVega AlvaroVega commented Oct 2, 2023 •
edited
Loading

Needed by test/unit/ngsiv2/ngsiService/subscriptions-test.js using MongoDB instead of Memory #1472

Maybe related #1086 ?

@AlvaroVega AlvaroVega marked this pull request as ready for review October 2, 2023 09:20
@fgalan
Copy link
Copy Markdown
Member

fgalan commented Oct 11, 2023

Not for version 3.5.0

@AlvaroVega AlvaroVega requested a review from fgalan February 5, 2024 08:41
@AlvaroVega
Copy link
Copy Markdown
Member Author

AlvaroVega commented Feb 5, 2024 •
edited
Loading

subscriptions are controlled by a subscription service:
https://github.com/telefonicaid/iotagent-node-lib/blob/master/lib/services/ngsi/subscriptionService.js

https://github.com/telefonicaid/iotagent-node-lib/blob/master/test/unit/ngsiv2/ngsiService/subscriptions-test.js

fgalan
fgalan reviewed Feb 5, 2024
View reviewed changes
Comment thread CHANGES_NEXT_RELEASE Outdated
fgalan
fgalan reviewed Feb 5, 2024
View reviewed changes
Comment thread CHANGES_NEXT_RELEASE Outdated
fgalan
fgalan approved these changes Feb 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 301280a into master Feb 5, 2024
@fgalan fgalan deleted the fix/update_subscriptions_device branch February 5, 2024 15:46
@fgalan fgalan mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgalan fgalan fgalan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlvaroVega @fgalan