Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially resolves issue #111 . Based on reimport-scan API docs, following flags were added. When tags field is set in reimport-scan request, it actually do not tag anything other than the Test named "Kubernetes (Trivy Operator Scan)" of created Engagement. Not sure, if tagging product or engagement is supported through this endpoint. Setting apply_tags_to_findings and apply_tags_to_endpoints is more useful and working as intended.
Added flags:
Docs for local development were updated. Without DEFECT_DOJO_PRODUCT_TYPE_NAME sending request to scan reimport failed with 400 code and client error.