Fix root daemon access when running with embedded root daemon#4050
Merged
thallgren merged 1 commit intorelease/v2from Feb 9, 2026
Merged
Fix root daemon access when running with embedded root daemon#4050thallgren merged 1 commit intorelease/v2from
thallgren merged 1 commit intorelease/v2from
Conversation
thallgren
force-pushed
the
thallgren/embedded-root-failure
branch
from
a146865 to
30e6856
Compare
When the user daemon runs with an embedded root daemon (e.g., in Docker mode), calls to RootDaemonVersion and withRootDaemon failed because they didn't account for the in-process root session. RootDaemonVersion now returns the local version directly, and withRootDaemon delegates to the session's WithRootClient when a session is available. Signed-off-by: Thomas Hallgren <thomas@tada.se>
thallgren
force-pushed
the
thallgren/embedded-root-failure
branch
from
30e6856 to
b9dffa5
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RootDaemonVersionto return the local version directly when root daemon is embedded (in-process)withRootDaemonto delegate to the session'sWithRootClientwhen a session is available, instead of returning an "embedded" errorCloses #4049
Test plan
telepresence connecton Windows in an elevated (administrator) terminaltelepresence logleveland other commands work with embedded root daemon