Skip to content

telink: add tl7218x modual board overlay - #49

Open
wuhaoTelink wants to merge 2 commits into
dev-tlk_v1.5from
feat-add-modual-board-overlay
Open

telink: add tl7218x modual board overlay#49
wuhaoTelink wants to merge 2 commits into
dev-tlk_v1.5from
feat-add-modual-board-overlay

Conversation

@wuhaoTelink

@wuhaoTelink wuhaoTelink commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR adds 2MB flash partition overlay support for the Telink TL7218X ML7G and ML7M module boards, and updates the Zephyr revision to pull up the SWS pin after startup and retention reset.

What was changed:

  • Add 4 new flash overlay files under src/platform/telink/:
    • tl7218x_ml7g_2m_flash.overlay / tl7218x_ml7m_2m_flash.overlay — dual image-0/image-1 slots with storage (matter-nvs), user, secure, dual-mode, dac-keypair, factory-data and vendor-data partitions.
    • tl7218x_ml7g_2m_flash_lzma.overlay / tl7218x_ml7m_2m_flash_lzma.overlay — LZMA-compressed image layout with dedicated image-0-matter, image-0-zb, image-0-trailor sub-partitions and zigbee-nvs.
  • Update the Zephyr revision pinned in .github/workflows/examples-telink.yaml (d6a8aa9…0858e43…) to pick up the fix that pulls up the SWS pin after startup and retention reset, preventing the debug tool connection issue.

Why:

The TL7218X ML7G/ML7M module boards ship with 2MB flash, which needs dedicated partition overlays to properly layout the Matter image, storage, and Zigbee NVS partitions in both standard and LZMA-compressed modes. The Zephyr revision bump is required for the SWS pin pull-up fix on these boards.

Related issues

N/A

Testing

Currently compiling and testing.

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the code readable:

  • PR title is https://project-chip.github.io/connectedhomeip-doc/contributing/pull_request_guidelines.html#title-formatting
  • Apply the https://project-chip.github.io/connectedhomeip-doc/style/CODING_STYLE_GUIDE.html rule (coding style)
  • PR size is short
  • Try to avoid "squashing" and "force-update" in commit history
  • CI time didn't increase

See: https://project-chip.github.io/connectedhomeip-doc/contributing/pull_request_guidelines.html

Summary by CodeRabbit

  • Improvements
    • Added dedicated 2 MB flash layouts for TL7218X ML7G and ML7M devices.
    • Defined storage regions for bootloader, firmware images, Matter/Zigbee data, configuration, security keys, factory data, and vendor data.
    • Updated the Telink SDK workflow to use a newer pinned repository revision.

Laiyue Wang added 2 commits September 4, 2026 13:58
Add flash partition overlays for the TL7218X ML7G and ML7M module
boards with 2MB flash, in both standard and LZMA image variants.

- tl7218x_ml7g_2m_flash.overlay / tl7218x_ml7m_2m_flash.overlay:
  dual image-0/image-1 slots with storage (matter-nvs), user,
  secure, dual-mode, dac-keypair, factory-data and vendor-data
  partitions.
- tl7218x_ml7g_2m_flash_lzma.overlay / tl7218x_ml7m_2m_flash_lzma.overlay:
  LZMA-compressed image layout with dedicated image-0-matter,
  image-0-zb, image-0-trailor sub-partitions and zigbee-nvs.

Signed-off-by: Laiyue Wang <laiyue.wang@telink-semi.com>
Pull-up SWS pin after startup and retention reset.

Signed-off-by: Laiyue Wang <laiyue.wang@telink-semi.com>
@mergify

mergify Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: fa3bdcb9-d2cd-4906-92e1-bff43addf9ed

📥 Commits

Reviewing files that changed from the base of the PR and between 9511ac4 and 9d8d760.

📒 Files selected for processing (5)
  • .github/workflows/examples-telink.yaml
  • src/platform/telink/tl7218x_ml7g_2m_flash.overlay
  • src/platform/telink/tl7218x_ml7g_2m_flash_lzma.overlay
  • src/platform/telink/tl7218x_ml7m_2m_flash.overlay
  • src/platform/telink/tl7218x_ml7m_2m_flash_lzma.overlay

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds fixed 2 MiB flash layouts for four TL7218X variants and updates the Zephyr revision used by the Telink workflow. The Telink BLE SDK revision remains unchanged.

Changes

TL7218X Flash Layouts

Layer / File(s) Summary
Fixed flash partition maps
src/platform/telink/tl7218x_ml7g_2m_flash.overlay, src/platform/telink/tl7218x_ml7m_2m_flash.overlay, src/platform/telink/*_lzma.overlay
The overlays define flash at 0x20000000 with 2 MiB capacity. They add fixed partitions for bootloader, firmware images, Matter and Zigbee regions, storage, security data, keys, factory data, and vendor data.

Telink Workflow Revision

Layer / File(s) Summary
Zephyr revision update
.github/workflows/examples-telink.yaml
The workflow checks out Zephyr revision 0858e43f05a91d84ab2fed77f3849ff589510b24. The Telink BLE SDK hash remains unchanged.

Estimated code review effort: 2 (Simple) | ~15 minutes

Merge Risk: ⚪ Minimal · up to 9d8d7

No concrete merge-blocking risk remains in the reviewed changes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes the main change: adding a TL7218X module board overlay. It is related to the four new flash overlay files, although it contains a spelling error and does not mention the Zephyr rev…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat-add-modual-board-overlay

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the conflict label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants