Skip to content

west: update hal_telink - #846

Merged
damien0x0023 merged 2 commits into
telink-semi:dev-tlk_v4.1from
LloydWang328:feat-update_signature_verify
Sep 18, 2026
Merged

west: update hal_telink#846
damien0x0023 merged 2 commits into
telink-semi:dev-tlk_v4.1from
LloydWang328:feat-update_signature_verify

Conversation

@LloydWang328

@LloydWang328 LloydWang328 commented Sep 17, 2026

Copy link
Copy Markdown
  • update ECDSA signature verification by replacing software
    interfaces with Telink HW PKE module
  • update hal_telink revision from
    256bc47e2198b6ac39534a00898eaee9a38b17c5
    to
    pull/209/head

@LloydWang328
LloydWang328 marked this pull request as draft September 17, 2026 08:49
@damien0x0023

damien0x0023 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

@s07641069 @andriy-bilynskyy

We see a CI failure of Manifest because it forbids executing some tasks from fork repo.
Is that normal or we can just ignore it?

@andriy-bilynskyy

andriy-bilynskyy commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

This CI error seems strange. Previous and next PRs successfully passed this job
https://github.com/telink-semi/tl_zephyr/actions/workflows/manifest.yml

@andriy-bilynskyy

andriy-bilynskyy commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Probably it's relative to using fork.

@andriy-bilynskyy

andriy-bilynskyy commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Here there is security issue relative to run pull_request_target from fork... In that case user code can got an access to our secret tokens... This job is updated in upstream manifest.yml

@damien0x0023

damien0x0023 commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@andriy-bilynskyy @wuhaoTelink @LloydWang328

  1. Created new PR (actions: manifest: avoid checking out the PR HEAD #848) to update our manifest according to upstream fix.

  2. Backported the modification from develop to dev-tlk_v4.1 (the target branch in this PR) in another one ([Backport dev-tlk_v4.1] actions: manifest: avoid checking out the PR HEAD #849).

  3. Forced push the same commit to pass Manifest check (re-run failed jobs did not work because it use old snapchat of dev-tlk_v4.1 manifest file) and trigger new round of all CI actions.

  4. Please review the changes after all actions pass.

Laiyue Wang @damien0x0023
west: update hal_telink
8e255cb 
- update ECDSA signature verification by replacing software
interfaces with Telink HW PKE module
- update hal_telink revision from
256bc47e2198b6ac39534a00898eaee9a38b17c5
to
pull/209/head

Signed-off-by: Laiyue Wang <laiyue.wang@telink-semi.com>
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
@damien0x0023
damien0x0023 force-pushed the feat-update_signature_verify branch from 55119cc to 8e255cb Compare September 18, 2026 04:51
@andriy-bilynskyy

andriy-bilynskyy commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_telink telink-semi/hal_telink@256bc47 telink-semi/hal_telink@1ecdb73 (dev-tlk_v1.0) telink-semi/hal_telink@256bc47e..1ecdb738

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@damien0x0023
west: update hal_telink revision to a specific commit
3cb9185 
- update hal_telink from
pull/209/head
to
1ecdb738c8eb06208c88ac3b9474d1f2f4936dab

Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
@damien0x0023
damien0x0023 marked this pull request as ready for review September 18, 2026 08:20
@damien0x0023
damien0x0023 merged commit dcf42ab into telink-semi:dev-tlk_v4.1 Sep 18, 2026
21 of 22 checks passed
@damien0x0023 damien0x0023 mentioned this pull request Sep 20, 2026
Merged
damien0x0023 added a commit that referenced this pull request Sep 20, 2026
Laiyue Wang @damien0x0023
west: verify ecdsa signature faster (#846)
7cd7cb3 
- update ECDSA signature verification by replacing
software interfaces with Telink HW PKE module
- update hal_telink revision from
256bc47e2198b6ac39534a00898eaee9a38b17c5
to
1ecdb738c8eb06208c88ac3b9474d1f2f4936dab

---------

Signed-off-by: Laiyue Wang <laiyue.wang@telink-semi.com>
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
Co-authored-by: Laiyue Wang <laiyue.wang@telink-semi.com>
Co-authored-by: Damien Ji <yinghao.ji@telink-semi.com>
(cherry picked from commit dcf42ab)
@damien0x0023 damien0x0023 mentioned this pull request Sep 20, 2026
Closed
damien0x0023 added a commit that referenced this pull request Sep 20, 2026
@damien0x0023
west: update hal_telink & telink_ble_sdk to sync #852 (backport #846 + …
d4f58b0 
…#852)

Extend the #846 backport with the manifest revision updates from #852
(refactor: tl5218x: update the lpd level with driver condfirmed.):
- hal_telink:     1ecdb738... -> 31f167f86a5ea2bd28e4c07c598586ae72bd332e
- telink_ble_sdk: f1fcb2e0...  -> 169a4bddb989da595d261db464584b84443b86b9

Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
damien0x0023 added a commit that referenced this pull request Sep 20, 2026
@damien0x0023
west: update hal_telink & telink_ble_sdk (#846, #852)
d5552d0 
Extend the #846 backport with the manifest revision updates from #852
(refactor: tl5218x: update the lpd level with driver condfirmed):

- hal_telink:     1ecdb738 -> 31f167f86a5ea2bd28e4c07c598586ae72bd332e
- telink_ble_sdk: f1fcb2e0 -> 169a4bddb989da595d261db464584b84443b86b9

Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
wuhaoTelink pushed a commit that referenced this pull request Sep 21, 2026
@damien0x0023 Laiyue Wang
[Backport release-v1.4-v4.1-branch] west: update hal_telink & telink_…
0ea2454 
…ble_sdk (#846, #852) (#862)

Backport the manifest revision updates from #846 (west: verify ecdsa
signature faster) and #852 (refactor: tl5218x: update the lpd level with
driver condfirmed.) into `release-v1.4-v4.1-branch`.

Changes (west.yml only):

- `hal_telink`: `256bc47e...` ->
`31f167f86a5ea2bd28e4c07c598586ae72bd332e`
- `telink_ble_sdk`: `f1fcb2e0...` ->
`169a4bddb989da595d261db464584b84443b86b9`

Commits: `7cd7cb35fa7f` (backport of #846), `d5552d051b71` (revision
updates from #852).

Closes the auto-generated backport tracking issues #859, #864, #865.

---------

Signed-off-by: Laiyue Wang <laiyue.wang@telink-semi.com>
Signed-off-by: Damien Ji <yinghao.ji@telink-semi.com>
Co-authored-by: Laiyue Wang <laiyue.wang@telink-semi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andriy-bilynskyy andriy-bilynskyy andriy-bilynskyy approved these changes
@damien0x0023 damien0x0023 Awaiting requested review from damien0x0023
@s07641069 s07641069 Awaiting requested review from s07641069
@wuhaoTelink wuhaoTelink Awaiting requested review from wuhaoTelink
@pulin1103 pulin1103 Awaiting requested review from pulin1103
@strandingneko-vivi strandingneko-vivi Awaiting requested review from strandingneko-vivi
@haiwentelink haiwentelink Awaiting requested review from haiwentelink
@fengtai-telink fengtai-telink Awaiting requested review from fengtai-telink

Assignees

@LloydWang328 LloydWang328

Labels

manifest manifest-hal_telink

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LloydWang328 @damien0x0023 @andriy-bilynskyy