Skip to content

Update foundry.mdx[Fix Foundry script] #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yjshi2015
Copy link
Contributor

Description

Adjust Foundry’s deploy and verify scripts to match the Telos EVM chain

The original deploy and verify scripts will prompt custom error: EIP-1559 not activated and ETHERSCAN_API_KEY must be set errors when executed, because the contract needs to be deployed on the Telos EVM chain, not Ethereum, so it is necessary to specify the Telos EVM corresponding verifier sourcify instead of the default etherscan;

In addition, perhaps Telos EVM does not yet support the EIP-1559 protocol, so it is necessary to specify the —legacy parameter to specify the transaction format before the London hard fork. Otherwise, it will prompt the EIP-1559 not activated error;

Test scenarios

The updated script passed the test, for example, this transaction is an example of a successful test: https://testnet.teloscan.io/tx/0x57e32321fb4e259dcc6b62b1b6c9788803f5e6a070b6e473cc4edec974fe75c9

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

The original deploy and verify scripts will prompt `custom error: EIP-1559 not activated` and `ETHERSCAN_API_KEY must be set` errors when executed, because the contract needs to be deployed on the Telos EVM chain, not Ethereum, so it is necessary to specify the Telos EVM corresponding validator `sourcify` instead of the default `etherscan`;
In addition, perhaps Telos EVM does not yet support the `EIP-1559` protocol, so it is necessary to specify the `—legacy` parameter to specify the transaction format before the London hard fork. Otherwise, it will prompt the `EIP-1559 not activated` error;
The updated script passed the test, for example, this transaction is an example of a successful test: https://testnet.teloscan.io/tx/0x57e32321fb4e259dcc6b62b1b6c9788803f5e6a070b6e473cc4edec974fe75c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant