refactor: coap request params up the call tree#15
Open
Conversation
Currently the coap request parameters are hard coded on the coap libraries Coap.js and Coapclient.js. The parameters should come from higher levers in the call tree. Also, the knowledge of what kind of coap payload the ELL-i light fixtures want should be in another library specific for them. Suspected file changes: client.js Coap.js Coapclient.js ELL-i-fixture.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the coap request parameters are hard coded on the coap
libraries Coap.js and Coapclient.js. The parameters should come from
higher levers in the call tree.
Also, the knowledge of what kind of coap payload the ELL-i light
fixtures want should be in another library specific for them.
Suspected file changes:
client.js
Coap.js
Coapclient.js
ELL-i-fixture.js