fix(shell): detach CLI-detection probes from the controlling terminal - #98
Merged
gsvprharsha merged 1 commit intoAug 26, 2026
Merged
Conversation
|
@AniketR10 is attempting to deploy a commit to the Harsha's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a Linux bug where launching Tempest from a terminal gave you a white window that wouldn't close — the CLI-detection probes run through an interactive login shell (bash -lic), which tries to take the terminal, gets stopped by SIGTTIN, and wedges the app's whole process group with it.
Fix is a setsid() on those probes so they get their own session with no terminal to fight over. macOS never hit this because Finder-launched apps have no controlling terminal to inherit.