Skip to content

Keep VersionSummary and VersionLocalState in sync #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shivs11
Copy link
Member

@Shivs11 Shivs11 commented May 1, 2025

READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.

What changed?

  • Added missing fields from VersionLocalState that were not present in VersionSummary.

Why?

  • Seems like the UI is querying a bunch of different places to get information about a specific version. This might be annoying and the aim of this PR is to make VersionSummary the place to go for information related to a specific version.
  • This shall also reduce the number of API calls to get information about a version.

Breaking changes

Server PR

@Shivs11 Shivs11 requested review from a team as code owners May 1, 2025 14:28
@Shivs11 Shivs11 changed the base branch from master to versioning-3.2 May 1, 2025 14:29
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no specific knowledge on these fields or this project, but nothing seems off from a general API quality standpoint, may want SDK review from someone more familiar with this project)

@Shivs11 Shivs11 changed the base branch from versioning-3.2 to master May 7, 2025 20:18
@Shivs11
Copy link
Member Author

Shivs11 commented May 7, 2025

I changed the base branch to be master since the versioning crew has decided, for the purpose of moving faster, to not have a feature-branch. This would also encourage the crew opening the corresponding server PR's asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants