-
Notifications
You must be signed in to change notification settings - Fork 93
VersionLocalState in sync with VersionSummary + Activation/Deactivation timestamps #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
07dcfaa
42c5c50
36d69be
a59aebe
ac49d06
6fa3aff
c71337b
8aca99d
ee8e6b0
e683888
7e863db
d419206
e4d2b3b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,6 +113,11 @@ message WorkerDeploymentVersionInfo { | |
| // Nil if not ramping. Updated when the version first starts ramping, not on each ramp change. | ||
| google.protobuf.Timestamp ramping_since_time = 6; | ||
|
|
||
| // Timestamp when this version first became current or ramping. | ||
| google.protobuf.Timestamp first_activation_time = 11; | ||
| // Timestamp when this version last stopped being current or ramping. | ||
| google.protobuf.Timestamp last_deactivation_time = 12; | ||
|
|
||
| // Range: [0, 100]. Must be zero if the version is not ramping (i.e. `ramping_since_time` is nil). | ||
| // Can be in the range [0, 100] if the version is ramping. | ||
| float ramp_percentage = 7; | ||
|
|
@@ -188,7 +193,25 @@ message WorkerDeploymentInfo { | |
| // The fully-qualified string representation of the version, in the form "<deployment_name>.<build_id>". | ||
| string version = 1; | ||
| google.protobuf.Timestamp create_time = 2; | ||
| // Deprecated. Use `drainage_info` instead. | ||
| enums.v1.VersionDrainageStatus drainage_status = 3; | ||
| // Information about workflow drainage to help the user determine when it is safe | ||
| // to decommission a Version. Not present while version is current or ramping | ||
| VersionDrainageInfo drainage_info = 4; | ||
| // Nil if not current. | ||
| // (-- api-linter: core::0140::prepositions=disabled | ||
| // aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --) | ||
| google.protobuf.Timestamp current_since_time = 5; | ||
| // Nil if not ramping. Updated when the version first starts ramping, not on each ramp change. | ||
|
Shivs11 marked this conversation as resolved.
Outdated
|
||
| // (-- api-linter: core::0140::prepositions=disabled | ||
| // aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --) | ||
| google.protobuf.Timestamp ramping_since_time = 6; | ||
| // Last time `current_since_time`, `ramping_since_time, or `ramp_percentage` of this version changed. | ||
| google.protobuf.Timestamp routing_update_time = 7; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit:
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the suggestion! Hmm, I still am leaning towards Not making this change right now, but let me know if you still feel strongly about this. |
||
| // Timestamp when this version first became current or ramping. | ||
| google.protobuf.Timestamp first_activation_time = 8; | ||
| // Timestamp when this version last stopped being current or ramping. | ||
| google.protobuf.Timestamp last_deactivation_time = 9; | ||
| } | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.