Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion openapi/openapiv2.json
Original file line number Diff line number Diff line change
Expand Up @@ -7008,7 +7008,37 @@
"format": "date-time"
},
"drainageStatus": {
"$ref": "#/definitions/v1VersionDrainageStatus"
"$ref": "#/definitions/v1VersionDrainageStatus",
"description": "Deprecated. Use `drainage_info` instead."
},
"drainageInfo": {
"$ref": "#/definitions/v1VersionDrainageInfo",
"title": "Information about workflow drainage to help the user determine when it is safe\nto decommission a Version. Not present while version is current or ramping"
},
"currentSinceTime": {
"type": "string",
"format": "date-time",
"description": "Nil if not current."
},
"rampingSinceTime": {
"type": "string",
"format": "date-time",
"description": "Nil if not ramping. Updated when the version first starts ramping, not on each ramp change."
},
"routingUpdateTime": {
"type": "string",
"format": "date-time",
"description": "Last time `current_since_time`, `ramping_since_time, or `ramp_percentage` of this version changed."
},
"firstActivationTime": {
"type": "string",
"format": "date-time",
"description": "Timestamp when this version first became current or ramping."
},
"lastDeactivationTime": {
"type": "string",
"format": "date-time",
"description": "Timestamp when this version last stopped being current or ramping."
}
}
},
Expand Down Expand Up @@ -14761,6 +14791,16 @@
"format": "date-time",
"description": "\nNil if not ramping. Updated when the version first starts ramping, not on each ramp change."
},
"firstActivationTime": {
"type": "string",
"format": "date-time",
"description": "Timestamp when this version first became current or ramping."
},
"lastDeactivationTime": {
"type": "string",
"format": "date-time",
"description": "Timestamp when this version last stopped being current or ramping."
},
"rampPercentage": {
"type": "number",
"format": "float",
Expand Down
41 changes: 41 additions & 0 deletions openapi/openapiv3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12056,7 +12056,40 @@ components:
- VERSION_DRAINAGE_STATUS_DRAINING
- VERSION_DRAINAGE_STATUS_DRAINED
type: string
description: Deprecated. Use `drainage_info` instead.
format: enum
drainageInfo:
allOf:
- $ref: '#/components/schemas/VersionDrainageInfo'
description: |-
Information about workflow drainage to help the user determine when it is safe
to decommission a Version. Not present while version is current or ramping
currentSinceTime:
type: string
description: |-
Nil if not current.
(-- api-linter: core::0140::prepositions=disabled
aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
format: date-time
rampingSinceTime:
type: string
description: |-
Nil if not ramping. Updated when the version first starts ramping, not on each ramp change.
(-- api-linter: core::0140::prepositions=disabled
aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
format: date-time
routingUpdateTime:
type: string
description: Last time `current_since_time`, `ramping_since_time, or `ramp_percentage` of this version changed.
format: date-time
firstActivationTime:
type: string
description: Timestamp when this version first became current or ramping.
format: date-time
lastDeactivationTime:
type: string
description: Timestamp when this version last stopped being current or ramping.
format: date-time
WorkerDeploymentOptions:
type: object
properties:
Expand Down Expand Up @@ -12112,6 +12145,14 @@ components:
aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
Nil if not ramping. Updated when the version first starts ramping, not on each ramp change.
format: date-time
firstActivationTime:
type: string
description: Timestamp when this version first became current or ramping.
format: date-time
lastDeactivationTime:
type: string
description: Timestamp when this version last stopped being current or ramping.
format: date-time
rampPercentage:
type: number
description: |-
Expand Down
23 changes: 23 additions & 0 deletions temporal/api/deployment/v1/message.proto
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ message WorkerDeploymentVersionInfo {
// Nil if not ramping. Updated when the version first starts ramping, not on each ramp change.
google.protobuf.Timestamp ramping_since_time = 6;

// Timestamp when this version first became current or ramping.
google.protobuf.Timestamp first_activation_time = 11;
// Timestamp when this version last stopped being current or ramping.
google.protobuf.Timestamp last_deactivation_time = 12;

// Range: [0, 100]. Must be zero if the version is not ramping (i.e. `ramping_since_time` is nil).
// Can be in the range [0, 100] if the version is ramping.
float ramp_percentage = 7;
Expand Down Expand Up @@ -188,7 +193,25 @@ message WorkerDeploymentInfo {
// The fully-qualified string representation of the version, in the form "<deployment_name>.<build_id>".
string version = 1;
google.protobuf.Timestamp create_time = 2;
// Deprecated. Use `drainage_info` instead.
enums.v1.VersionDrainageStatus drainage_status = 3;
// Information about workflow drainage to help the user determine when it is safe
// to decommission a Version. Not present while version is current or ramping
VersionDrainageInfo drainage_info = 4;
// Nil if not current.
Comment thread
Shivs11 marked this conversation as resolved.
Outdated
// (-- api-linter: core::0140::prepositions=disabled
// aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
google.protobuf.Timestamp current_since_time = 5;
// Nil if not ramping. Updated when the version first starts ramping, not on each ramp change.
Comment thread
Shivs11 marked this conversation as resolved.
Outdated
// (-- api-linter: core::0140::prepositions=disabled
// aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
google.protobuf.Timestamp ramping_since_time = 6;
// Last time `current_since_time`, `ramping_since_time, or `ramp_percentage` of this version changed.
google.protobuf.Timestamp routing_update_time = 7;
Copy link
Copy Markdown

@drewhoskins-temporal drewhoskins-temporal May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: last_routing_update_time for clarity?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! Hmm, I still am leaning towards routing_update_time since the word 'update' already implies the latest change, so adding last_ felt a bit redundant to me.

Not making this change right now, but let me know if you still feel strongly about this.

// Timestamp when this version first became current or ramping.
google.protobuf.Timestamp first_activation_time = 8;
// Timestamp when this version last stopped being current or ramping.
google.protobuf.Timestamp last_deactivation_time = 9;
}
}

Expand Down
Loading