Skip to content

Add identity param to reset API #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add identity param to reset API #590

wants to merge 4 commits into from

Conversation

gow
Copy link
Contributor

@gow gow commented May 14, 2025

READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.

Adding 2 1 new parameter to Reset API request.

  1. identity - needed to capture the identity of the worker/client making the operation.
  2. terminate_child_workflow_if_necessary - allows operators to optionally terminate child workflows that were started after the reset-point

terminate_child_workflow_if_necessary is needed to unblock parent after reset in some in cases where WorkflowIdConflictPolicy prevents the new child from being started.

@gow gow requested review from a team as code owners May 14, 2025 22:00
@gow gow requested a review from drewhoskins-temporal May 16, 2025 18:35
@gow gow changed the title Add terminate_child_workflow_if_necessary & identity params to reset API Add identity param to reset API May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants