add create_request_id to child initiated event #598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
hai719
changed the title
yycptt
approved these changes
May 27, 2025
cretz
reviewed
May 27, 2025
| @@ -665,6 +665,9 @@ message StartChildWorkflowExecutionInitiatedEventAttributes { | |||
| bool inherit_build_id = 19; | |||
| // Priority metadata | |||
| temporal.api.common.v1.Priority priority = 20; | |||
| // A unique identifier for the request to start this child workflow execution. This is used to | |||
| // deduplicate requests to start a child workflow execution with the same workflow ID. | |||
| string create_request_id = 21; | |||
There was a problem hiding this comment.
Suggested change
| string create_request_id = 21; | |
| string request_id = 21; |
May not need the create_ prefix, but not a big deal
| @@ -665,6 +665,9 @@ message StartChildWorkflowExecutionInitiatedEventAttributes { | |||
| bool inherit_build_id = 19; | |||
| // Priority metadata | |||
| temporal.api.common.v1.Priority priority = 20; | |||
| // A unique identifier for the request to start this child workflow execution. This is used to | |||
| // deduplicate requests to start a child workflow execution with the same workflow ID. | |||
| string create_request_id = 21; | |||
There was a problem hiding this comment.
Will this event be in the map at WorkflowExecutionExtendedInfo.request_id_infos when describing a workflow?
There was a problem hiding this comment.
No. Child workflow's executionState.RequestIds[StartRequest.GetRequestId()] stores startEvent of the child workflow. (code)
| @@ -665,6 +665,9 @@ message StartChildWorkflowExecutionInitiatedEventAttributes { | |||
| bool inherit_build_id = 19; | |||
| // Priority metadata | |||
| temporal.api.common.v1.Priority priority = 20; | |||
| // A unique identifier for the request to start this child workflow execution. This is used to | |||
| // deduplicate requests to start a child workflow execution with the same workflow ID. | |||
| string create_request_id = 21; | |||
There was a problem hiding this comment.
This is used to deduplicate requests to start a child workflow execution with the same workflow ID.
I assume the tuple of workflow run ID + event ID is not enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
Add request_id to child initiated event.
Why
For event-based replication, if request_id is not replicated to standby clusters, after failover, standby cannot dedup the start workflow request.
Breaking changes
Server PR
temporalio/temporal#7813