Skip to content

Add start delay field to StartActivityExecutionRequest #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fretz12 merged 3 commits into from
Apr 24, 2026
Merged

Add start delay field to StartActivityExecutionRequest #767

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47fdfcd
add start delay to StartActivityExecutionRequest
fretz12 Apr 22, 2026
b4a09df
Merge branch 'master' into fredtzeng/saa-start-delay
fretz12 Apr 24, 2026
2f29dbb
update start delay doc
fretz12 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openapi/openapiv2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10470,6 +10470,10 @@
"onConflictOptions": {
"$ref": "#/definitions/apiCommonV1OnConflictOptions",
"description": "Options for handling conflicts when using ACTIVITY_ID_CONFLICT_POLICY_USE_EXISTING."
},
"startDelay": {
"type": "string",
"description": "Time to wait before dispatching the activity."
}
}
},
Expand Down
4 changes: 4 additions & 0 deletions openapi/openapiv3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14375,6 +14375,10 @@ components:
allOf:
- $ref: '#/components/schemas/OnConflictOptions'
description: Options for handling conflicts when using ACTIVITY_ID_CONFLICT_POLICY_USE_EXISTING.
startDelay:
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
type: string
description: Time to wait before dispatching the activity.
StartActivityExecutionResponse:
type: object
properties:
Expand Down
2 changes: 2 additions & 0 deletions temporal/api/workflowservice/v1/request_response.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3000,6 +3000,8 @@ message StartActivityExecutionRequest {
repeated temporal.api.common.v1.Link links = 20;
// Options for handling conflicts when using ACTIVITY_ID_CONFLICT_POLICY_USE_EXISTING.
temporal.api.common.v1.OnConflictOptions on_conflict_options = 21;
// Time to wait before dispatching the activity.
Copy link
Copy Markdown
Contributor

@dandavison dandavison Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is a bit clearer to me and matches the language in the workflow start_delay comments.

Suggested change
// Time to wait before dispatching the activity.
// Time to wait before dispatching the first activity task.

Copy link
Copy Markdown
Contributor Author

@fretz12 fretz12 Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to make a bit clearer. @Sushisource had previously mentioned the first sounded confusing.

// Time to wait before dispatching the activity. This delay is not applied to retry attempts.

LMK thoughts

Copy link
Copy Markdown
Contributor Author

@fretz12 fretz12 Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion Dan still prefers the task word. "So the more explicit/technical version made sense to me; for "activities" themselves, users are familiar with "starting" them, but even there there's confusion with "scheduling" , so I thought best not to add a 3rd verb"

google.protobuf.Duration start_delay = 22;
}

message StartActivityExecutionResponse {
Expand Down
Loading