Skip to content

feat: add metrics configuration to soak-test deployment#22

Merged
robholland merged 1 commit intotemporalio:mainfrom
Biolevate:main
Sep 25, 2025
Merged

feat: add metrics configuration to soak-test deployment#22
robholland merged 1 commit intotemporalio:mainfrom
Biolevate:main

Conversation

@wtf-is-flying
Copy link
Copy Markdown
Contributor

@wtf-is-flying wtf-is-flying commented Sep 15, 2025

What was changed

This patch adds a metric named port and a PROMETHEUS_ENDPOINT environment variable to the soak-test deployment.

Why?

I am trying to follow this blog post https://temporal.io/blog/scaling-temporal-the-basics to scale up my Temporal Service.

Unfortunately, I wasn't able to collect StartExecutionWorkflow latencies. I found that the deployment configuration was missing both a metric named port and a PROMETHEUS_ENDPOINT environment variable, which explained why I wasn't collecting any metric from this deployment.

Checklist

  1. How was this tested:

This is a before/after view 🙂 we notice that we start collecting StartExecutionWorkflow request latencies.

image

@wtf-is-flying wtf-is-flying requested a review from a team as a code owner September 15, 2025 14:30
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 15, 2025

CLA assistant check
All committers have signed the CLA.

@wtf-is-flying
Copy link
Copy Markdown
Contributor Author

I can't sign the CLA (Version selector/field is empty). 🙁

@robholland
Copy link
Copy Markdown
Collaborator

Can you try the CLA thing again? It's a bit flakey unfortunately :(

@wtf-is-flying
Copy link
Copy Markdown
Contributor Author

It's done!

@robholland robholland merged commit e348614 into temporalio:main Sep 25, 2025
5 checks passed
@robholland
Copy link
Copy Markdown
Collaborator

Merged and released new chart version, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants