GH action to update submodule#26
Merged
donald-pinckney merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
![semgrep-managed-scans[bot]](https://avatars.githubusercontent.com/u/56493103?s=60&v=4){kind=small}
Comment on lines
+14
to
+47
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout dev branch | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: dev | ||
| submodules: true | ||
| # Use default GITHUB_TOKEN — has push access to the repo | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Update submodule to latest dev | ||
| run: | | ||
| cd plugins/temporal-developer/skills/temporal-developer | ||
| git fetch origin dev | ||
| git checkout origin/dev | ||
| cd "$GITHUB_WORKSPACE" | ||
|
|
||
| - name: Check for changes | ||
| id: check | ||
| run: | | ||
| if git diff --quiet; then | ||
| echo "changed=false" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "changed=true" >> "$GITHUB_OUTPUT" | ||
| fi | ||
|
|
||
| - name: Commit and push | ||
| if: steps.check.outputs.changed == 'true' | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
| git add plugins/temporal-developer/skills/temporal-developer | ||
| git commit -m "update submodule to latest dev" | ||
| git push origin dev |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by missing-explicit-permissions.
You can view more details about this finding in the Semgrep AppSec Platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds a GH action which bumps the skill submodule pointer to the latest SHA, and pushes a commit doing so. This only changes the
devbranch ofagent-skills, and only uses SHAs from thedevbranch ofskill-temporal-developer.Why?
It is quite annoying to manually make submodule updating commits, and at least for the
devbranches we do always want them to be in sync.Checklist
Closes
How was this tested:
Will have to test after merging.
Any docs updates needed?
No