Add custom livenessProbe for Temporal services (Feature Request #653)#654
Open
Kiseloff wants to merge 1 commit intotemporalio:mainfrom
Open
Add custom livenessProbe for Temporal services (Feature Request #653)#654Kiseloff wants to merge 1 commit intotemporalio:mainfrom
Kiseloff wants to merge 1 commit intotemporalio:mainfrom
Conversation
5e275e9 to
935d015
Compare
|
@Temporal-Team @temporal-data any update on this? Would be very happy if you could take a look at this. |
Contributor
|
Happy to accept this, please add tests as appropriate though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
User can set custom livenessProbe for Frontend/History/Matching services via values.
Why?
Sometimes service can loose connectivity to database and it needs to have a possibility to check this event and restart service to reconnect it to DB.
Checklist
Closes [Feature Request] There is no way to configure custom livenessProbe for Temporal services #653
How was this tested:
you can set custom livenessProbe via values.yaml and look at rendered template for deployments.
Any docs updates needed?
nothing to update