fix: web ui uses internalFrontend when available#724
Open
golgoth31 wants to merge 1 commit intotemporalio:mainfrom
Open
fix: web ui uses internalFrontend when available#724golgoth31 wants to merge 1 commit intotemporalio:mainfrom
golgoth31 wants to merge 1 commit intotemporalio:mainfrom
Conversation
|
|
|
|
Signed-off-by: David Sabatie <david.sabatie@notrenet.com>
golgoth31
force-pushed
the
fix/web-ui-uses-internal-frontend
branch
from
ebf6967 to
fc44bdb
Compare
robholland
requested changes
Apr 10, 2026
| imagePullPolicy: {{ .Values.web.image.pullPolicy }} | ||
| env: | ||
| - name: TEMPORAL_ADDRESS | ||
| {{- if and (hasKey .Values.server "internalFrontend") .Values.server.internalFrontend.enabled .Values.web.useInternalFrontend }} |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- if and (hasKey .Values.server "internalFrontend") .Values.server.internalFrontend.enabled .Values.web.useInternalFrontend }} | |
| {{- if and (index .Values.server "internal-frontend").enabled .Values.web.useInternalFrontend }} |
| env: | ||
| - name: TEMPORAL_ADDRESS | ||
| {{- if and (hasKey .Values.server "internalFrontend") .Values.server.internalFrontend.enabled .Values.web.useInternalFrontend }} | ||
| value: "{{ include "temporal.fullname" $ }}-internal-frontend.{{ .Release.Namespace }}.svc:{{ .Values.server.internalFrontend.service.port }}" |
Contributor
There was a problem hiding this comment.
Suggested change
| value: "{{ include "temporal.fullname" $ }}-internal-frontend.{{ .Release.Namespace }}.svc:{{ .Values.server.internalFrontend.service.port }}" | |
| value: {{ include "temporal.fullname" $ }}-internal-frontend:{{ (index $.Values.server "internal-frontend").service.port }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This pull request allow the web ui to use the internal frontend when it's available.
Why?
With the current configuration the web ui is only linked to the common frontend, when anabling authorization on this frontend, the UI is enable to work properly. Using the internal frontend allows using a different OIDC provider for jwt access then the jwt authorization in the frontend.
Checklist
Closes [Feature Request] Temporal UI use internal-frontend #706
How was this tested:
deployed and working in our system.
Any docs updates needed?