feat: Allow the ability to configure garbage collection on schema-job.#761
Closed
PurseChicken wants to merge 0 commit intotemporalio:mainfrom
Closed
feat: Allow the ability to configure garbage collection on schema-job.#761PurseChicken wants to merge 0 commit intotemporalio:mainfrom
PurseChicken wants to merge 0 commit intotemporalio:mainfrom
Conversation
|
|
Author
|
This was replaced with #857 due to the overhaul of the upstream chart. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR gives the user the ability to configure schema-job garbage collection. Specifically the ability to enable or disable the garbage collection altogether as well as specify the desired time before garbage collection runs against the job if enabled.
See Here for more information about kubernetes garbage collection on job resources.
Why?
Currently garbage collection (.spec.ttlSecondsAfterFinished) is hard coded in the server-job manifest. This means that the job will always delete itself after the specified value (currently 86400). In some cases users may want to either configure the number of seconds before deleting the job manifest, or they may want to disable this garbage collection altogether. This PR takes care of both of those scenarios.
Checklist
Closes [Feature Request] Allow Schema Job ttlSecondsAfterFinished to be configurable #735
How was this tested:
The chart was validated using helm template --debug as well as packaging it (helm package) and using it in a deployment.
Any docs updates needed?
No