feat(helm): add extraObjects support#781
Merged
robholland merged 4 commits intotemporalio:mainfrom Mar 30, 2026
Merged
Conversation
- Add extraObjects configuration field to values.yaml - Create templates/extra-objects.yaml to render additional manifests - Update README.md with usage examples for ExternalSecretOperator and SealedSecrets - Add automated tests in tests/extra_objects_test.yaml - Enable GitOps-friendly secret management by allowing injection of custom resources Signed-off-by: Ralf Dahmen <ralf.dahmen14@googlemail.com>
Signed-off-by: Ralf Dahmen <ralf.dahmen14@googlemail.com>
|
I desperately need this lol |
robholland
requested changes
Jan 16, 2026
Contributor
robholland
left a comment
There was a problem hiding this comment.
Don't really like the name, but it seems that's the consensus. I agree with others that this should be a helm feature, but until then...
|
Can we add concise version mentioned by @robholland? {{ range .Values.extraObjects }}
---
{{ tpl . $ }}
{{ end }}What's the state of this PR? I really don't want to make a wrapper chart only to create additional secrets. Should I make another PR maybe? |
Contributor
|
@Ray-Barker Perhaps create a new PR as we've not heard back. |
Contributor
Author
|
Sorry for the long wait, @Ray-Barker and @robholland! Please have a look again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extraObjects support for external secret management
Problem
Temporal Helm charts currently create Kubernetes Secrets inline with base64-encoded sensitive data directly in chart templates. While this works for basic deployments, it creates significant challenges in GitOps workflows where sensitive data like database passwords are stored as base64-encoded strings in Git repositories, providing minimal security since base64 is easily reversible.
Solution
Add support for
extraObjectsconfiguration to allow injecting additional Kubernetes manifests, enabling external secret management solutions like ExternalSecretOperator or SealedSecrets.Changes
Configuration (
values.yaml)extraObjectsfield as an array of Kubernetes resource definitionsTemplate (
templates/extra-objects.yaml)extraObjectsarray---document separators for multi-document YAMLDocumentation (
README.md)Tests (
tests/extra_objects_test.yaml)Usage Examples
ExternalSecretOperator
SealedSecrets
Benefits
Testing
Related Issues
Closes #780 (GitOps secret management support)
Checklist