Skip to content

Simplify chart#784

Merged
robholland merged 26 commits intov1from
rh-simplify
Dec 5, 2025
Merged

Simplify chart#784
robholland merged 26 commits intov1from
rh-simplify

Conversation

@robholland
Copy link
Copy Markdown
Contributor

@robholland robholland commented Nov 19, 2025

What was changed

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

temporal-data and others added 12 commits August 6, 2025 19:10
@temporal-data
Update Chart to 0.65.0.
a7b5ab1
@robholland
Allow passing datacenter when creating the keyspace. (#748)
33101ca
@temporal-data
Update Chart to 0.66.0.
feb47c2
@ghaskins
Add support for "custom" persistence driver (#658)
feafc40 
Temporal core allows for the registration and configuration of custom data stores.
However, there is a disparity in how the helm chart translates persistence
configuration between helm values and the resulting configmap.

As an example, the temporal config for a custom driver for the default store may look
as so:

```
persistence:
  defaultStore: my-custom-store
  visibilityStore: es-visibility
  numHistoryShards: 4
  datastores:
    my-custom-store:
      customDatastore:
        name: "my-custom"
        options:
          hosts: "mycustom.example.com"
          keyspace: "temporal"
```

Translating to helm values would look like

```
server:
  config:
    persistence:
      defaultStore: my-custom-store
      additionalStores:
        my-custom-store:
          customDatastore:
            name: "my-custom"
            options:
              hosts: "mycustom.example.com"
              keyspace: "temporal"
```

This gets us most of the way there, but there are a few problems:

1. The charts always assume defaultStore = "default" and thus have opinions
   about subordinate structures such as default.driver.  This results in objects
   such as Secrets and Jobs being incorrectly emitted for default.driver = "cassandra" even
   though we are trying to specify an alternate store.  This logic should probably
   be $defaultStore.driver and $visibilityStore.driver instead.
2. The additionalStores configuration does not lend itself to first-class
   representation in conditional statements, even though it can be used to
   emit the resulting configmap correctly.

One could argue that we should clean up the helm representation to more closely align
with the temporal-server yaml, but this is a bigger task (and a breaking change).  Instead,
this patch ties into the existing model of using $store.driver = {cassandra, sql, elasticsearch}
and adds a 4th first-class type "custom."

The user may configure this as so:

```
server:
  config:
    persistence:
      default:
        driver: custom
      visibility:
        driver: custom
```

And in doing so, we instruct the various templates to elide the objects (Jobs, Secrets, etc.)
related to that store, leaving it to the user to supply the rest of the required configuration
using a combination of additionalStores, additionalEnv, additionalVolumeMounts, etc., to inject
configuration and secrets.  They would also, of course, be responsible for any DDL setup or
migration.

Signed-off-by: Greg Haskins <greg@manetu.com>
@temporal-data
Update Chart to 0.67.0.
8823829
@temporal-data
Update Chart to 0.68.0.
dc0134e
@PhillypHenning
admintools tag 1.29.0 -> 1.29 (#756)
223fb41
@temporal-data
Update Chart to 0.68.1.
9e34504
@temporal-data
Update Chart to 0.69.0.
790373a
@picatz
Set explicit permissions for GitHub Actions workflows (#765)
042c72c 
This change was made by an automated process to ensure all GitHub Actions workflows have explicitly defined permissions as per best practices.
@temporal-data
Update Chart to 0.70.0.
e887b93
@robholland
Simplify our helm chart.
ee8e6fc 
This removes sub-charts so that our chart is just responsible for installing Temporal.

Also change the values format to use the native server config YAML rather than
bad abstractions. This frees us to more easily support server features in the
future (such as secondary visibility).

Removes assumptions made about persistance store naming.

Greatly simplifies our helpers which were the biggest challenge to confidence
while making changes.
@semgrep-managed-scans
Copy link
Copy Markdown

semgrep-managed-scans Bot commented Nov 19, 2025

Semgrep found 1 missing-explicit-permissions finding:

No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).

@robholland robholland changed the base branch from main to v1 December 5, 2025 13:30
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 5, 2025 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ ghaskins
✅ robholland
✅ picatz
✅ PhillypHenning
❌ temporal-data
You have signed the CLA already but the status is still pending? Let us recheck it.

@robholland robholland marked this pull request as ready for review December 5, 2025 13:41
@robholland robholland requested a review from a team as a code owner December 5, 2025 13:41
@robholland robholland requested a review from a team December 5, 2025 14:36
@robholland
Update README to stop referring to external databases.
bc6e541 
Now that we no longer use sub-charts, databases are always external.
@robholland
Adjust config notes.
76bd960
@robholland robholland merged commit d2fd085 into v1 Dec 5, 2025
2 of 3 checks passed
@robholland robholland deleted the rh-simplify branch December 5, 2025 16:59
robholland added a commit that referenced this pull request Dec 18, 2025
@robholland @BrianKopp
@PhillypHenning @LeoDiazL @chaptersix @temporal-data @mattbrandman
V1 (#810)
aa5da97 
* Remove prometheus dependency (#534)
* Remove prometheus from dependencies and examples
* Remove grafana dependency (#526)
* Adjust some helper wiring.
* Update Server Configmap (#794)
* .ENV to env and add config template var
* Simplify chart (#784)

Simplify our helm chart, remove sub-charts.

* Install cluster variations as part of CI. (#796)
* Skip dockerize for 1.29.* images.

This allows us to use server templated config files safely on 1.29.* and 1.30.*
so that we can rollforward/backward without having to maintain two sets of configs.

* Schema refactor (#798)
* Refactor schema management.

This uses temporal-elasticsearch-tool where available, and a shell equivalent
otherwise.

Elasticsearch will now perform schema updates like Cassandra/SQL do.

Simplify the broken setup vs upgrade toggles which did not properly control the
behaviour. We don't have a way to with fixed toggles to separate creation from
upgrade. Use a single toggle for management, the user can toggle that after
install if they want to stop automatic upgrades.

* v1 doesn't have deps. (#800)
* Push to the branch on which the action was triggered.
* Update Chart to 1.0.0-rc.1.
* Add some upgrading notes. (#805)
* Fix version specifier. (#806)
* Change image pull secrets to array instead of map (#701)
* Correct config option name. (#807)
* Pin helm unittest version due to helm 3 vs 4 compat issue. (#808)
* Switch ct to testing against main.

---------

Co-authored-by: Brian Kopp <briankopp.usa@gmail.com>
Co-authored-by: PhilHenning <phillyp.henning@gmail.com>
Co-authored-by: LeoDiazL <leo@bitovi.com>
Co-authored-by: Phil Henning <philh@bitovi.com>
Co-authored-by: Alex Stanfield <13949480+chaptersix@users.noreply.github.com>
Co-authored-by: Temporal Data <commander-data@temporal.io>
Co-authored-by: Matthew Brandman <matthb6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaely520 michaely520 michaely520 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@robholland @CLAassistant @kenske @PhillypHenning @michaely520 @temporal-data @ghaskins @picatz